-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not need to set SupportIPVSProxyMode after 1.10. #62513
Conversation
Please check: https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L312 |
@m1093782566 yes, so that's why we need to remove it from configuration, there is no need to specify it explicitly. |
/test pull-kubernetes-e2e-kops-aws |
/lgtm |
the changes LGTM. needs rebase. |
@dims @m1093782566 done. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyliu513, m1093782566 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-bazel-test |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
SupportIPVSProxyMode
istrue
by default since 1.10, there is no need to set it explicitly any more./area ipvs
/cc @m1093782566