Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not need to set SupportIPVSProxyMode after 1.10. #62513

Merged
merged 1 commit into from Jun 20, 2018

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Apr 13, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

SupportIPVSProxyMode is true by default since 1.10, there is no need to set it explicitly any more.

/area ipvs

/cc @m1093782566

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/ipvs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2018
@m1093782566
Copy link
Contributor

SupportIPVSProxyMode is already default to true, right?

Please check: https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L312

@gyliu513
Copy link
Contributor Author

@m1093782566 yes, so that's why we need to remove it from configuration, there is no need to specify it explicitly.

@gyliu513 gyliu513 changed the title SupportIPVSProxyMode is true by default. Do not need to set SupportIPVSProxyMode after 1.10. Apr 13, 2018
@gyliu513
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@m1093782566
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2018
@m1093782566
Copy link
Contributor

m1093782566 commented Jun 7, 2018

@gyliu513

Please rebase this PR.

@dims Any chance to take a look at the /hack part?

@dims
Copy link
Member

dims commented Jun 7, 2018

the changes LGTM. needs rebase.

@k8s-ci-robot k8s-ci-robot added retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 7, 2018
@gyliu513
Copy link
Contributor Author

gyliu513 commented Jun 7, 2018

@dims @m1093782566 done.

@m1093782566
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyliu513
Copy link
Contributor Author

gyliu513 commented Jun 7, 2018

/test pull-kubernetes-bazel-test

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 24323e2 into kubernetes:master Jun 20, 2018
@gyliu513 gyliu513 deleted the ipvs-beta branch June 20, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants