Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addon-resizer version - 1.8.1 #63618

Merged
merged 3 commits into from
Oct 17, 2018
Merged

Fix addon-resizer version - 1.8.1 #63618

merged 3 commits into from
Oct 17, 2018

Conversation

tallclair
Copy link
Member

What this PR does / why we need it:

https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/prometheus/kube-state-metrics-deployment.yaml (added in #62849) should use the same addon-resizer version as other addons.

Release note:

NONE

@tallclair tallclair added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels May 9, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2018
@k8s-ci-robot k8s-ci-robot requested review from brancz and kawych May 9, 2018 18:38
@kawych
Copy link
Contributor

kawych commented Jun 7, 2018

Can you also add a config map for resource configuration and mount it? Example for metrics server: https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/metrics-server/metrics-server-deployment.yaml#L10

I see it's missing from Addon Resizer README (https://github.com/kubernetes/autoscaler/blob/master/addon-resizer/README.md), I'll create a PR to add it.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2018
@tallclair
Copy link
Member Author

Picked this up again, PTAL.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2018
@kawych
Copy link
Contributor

kawych commented Oct 12, 2018

Kubernetes addons switched to addon-resizer 1.8.3, please update.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2018
@tallclair
Copy link
Member Author

@kawych thanks, done. Also noticed the eventer-nanny configurations were left behind at 1.8.2, so I updated those as well.

@kawych
Copy link
Contributor

kawych commented Oct 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@kawych
Copy link
Contributor

kawych commented Oct 16, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@tallclair
Copy link
Member Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2c738b9 into kubernetes:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@kawych kawych Awaiting requested review from kawych

Assignees

@kawych kawych

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tallclair @kawych @fejta-bot @k8s-ci-robot @brancz