Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use subtest for table units (pkg/scheduler/api/validation) #63664

Merged
merged 1 commit into from
Nov 29, 2018
Merged

use subtest for table units (pkg/scheduler/api/validation) #63664

merged 1 commit into from
Nov 29, 2018

Conversation

xchapter7x
Copy link
Contributor

@xchapter7x xchapter7x commented May 10, 2018 •
edited

What this PR does / why we need it: Update scheduler's unit table tests to use subtest

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
breaks up PR: #63281
/ref #63267

Release note:

This PR will leverage subtests on the existing table tests for the scheduler units.
Some refactoring of error/status messages and functions to align with new approach.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2018
@xchapter7x xchapter7x mentioned this pull request May 10, 2018
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 10, 2018
@xchapter7x xchapter7x changed the title [WIP] use subtest for table units (pkg/scheduler/api/validation) use subtest for table units (pkg/scheduler/api/validation) May 10, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2018
@xchapter7x xchapter7x mentioned this pull request May 11, 2018
Closed
misterikkit
misterikkit reviewed May 11, 2018
View reviewed changes
pkg/scheduler/api/validation/validation_test.go Outdated
policy: api.Policy{Priorities: []api.PriorityPolicy{{Name: "WeightPriority", Weight: 2}}},
expected: nil,
},
{
name: "invalide negative weight policy",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: invalide

pkg/scheduler/api/validation/validation_test.go Outdated
policy: api.Policy{ExtenderConfigs: []api.ExtenderConfig{{URLPrefix: "http://127.0.0.1:8081/extender", FilterVerb: "filter"}}},
expected: nil,
},
{
name: "valid preemtverb and urlprefix",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: preemtverb

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo didn't get fixed, but otherwise LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I saw the comment and thought it was after fixed. I'm blind ...

@misterikkit
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2018
@xchapter7x
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@xchapter7x
Copy link
Contributor Author

/assign @bsalamat

@xchapter7x xchapter7x force-pushed the pkg-scheduler-api-validation branch from 5a4dacf to da9be7e Compare May 25, 2018 22:01
@xchapter7x
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@xchapter7x
Copy link
Contributor Author

/test pull-kubernetes-node-e2e
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@xchapter7x xchapter7x force-pushed the pkg-scheduler-api-validation branch from da9be7e to 233a01f Compare May 28, 2018 13:46
@bsalamat
Copy link
Member

/assign @misterikkit

resouer
resouer approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2018
@resouer
Copy link
Contributor

resouer commented May 30, 2018 •
edited

/lgtm cancel

Due to typo is still there: #63664 (comment)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2018
@xchapter7x
use subtest for table units
0acc56a 
fix typos in subtest name

  pr feedback:
  - kubernetes#63664 (review)

fix typo in test name

  kubernetes#63664 (comment)
@xchapter7x xchapter7x force-pushed the pkg-scheduler-api-validation branch from 233a01f to 0acc56a Compare June 8, 2018 15:30
@xchapter7x
Copy link
Contributor Author

/test pull-kubernetes-node-e2e

misterikkit
misterikkit reviewed Jun 11, 2018
View reviewed changes
pkg/scheduler/api/validation/validation_test.go
policy: api.Policy{ExtenderConfigs: []api.ExtenderConfig{{URLPrefix: "http://127.0.0.1:8081/extender", FilterVerb: "filter"}}},
expected: nil,
},
{
name: "valid preemt verb and urlprefix",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep coming back to typos: s/preemt/preempt/

@k82cn
Copy link
Member

k82cn commented Jul 18, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, xchapter7x

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2018
@resouer
Copy link
Contributor

resouer commented Nov 29, 2018

/lgtm

Thanks for fixing.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6d87c07 into kubernetes:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer approved these changes

@misterikkit misterikkit misterikkit left review comments

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@resouer resouer

@misterikkit misterikkit

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xchapter7x @misterikkit @bsalamat @resouer @k82cn @k8s-ci-robot @fejta-bot