Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #63806: kubeadm - do not generate etcd ca/certs for external etcd #64221

Merged
merged 1 commit into from May 29, 2018
Merged

Automated cherry pick of #63806: kubeadm - do not generate etcd ca/certs for external etcd #64221

merged 1 commit into from May 29, 2018
+27 −3

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented May 23, 2018

Cherry pick of #63806 on release-1.10.

#63806: kubeadm - do not generate etcd ca/certs for external etcd

@detiber @chuckha
kubeadm - do not generate etcd ca/certs for external etcd
7d5ea89 
Only generate the etcd CA and certificates if not configured for external
etcd.
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 23, 2018
timothysc
timothysc approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2018
@timothysc timothysc added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 23, 2018
@timothysc timothysc added this to the v1.10 milestone May 23, 2018
@timothysc timothysc added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed milestone/incomplete-labels labels May 23, 2018
@timothysc
Copy link
Member

/test pull-kubernetes-e2e-gce

1 similar comment
@chuckha
Copy link
Contributor Author

chuckha commented May 23, 2018

/test pull-kubernetes-e2e-gce

@chuckha
Copy link
Contributor Author

chuckha commented May 23, 2018

/test pull-kubernetes-e2e-kops-aws

@chuckha
Copy link
Contributor Author

chuckha commented May 23, 2018

/test pull-kubernetes-bazel-build

@chuckha
Copy link
Contributor Author

chuckha commented May 23, 2018

/test pull-kubernetes-e2e-kops-aws

@chuckha
Copy link
Contributor Author

chuckha commented May 29, 2018

/retest

luxas
luxas reviewed May 29, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@chuckha @luxas @timothysc

Pull Request Labels
  • sig/cluster-lifecycle: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, luxas, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit b4e2155 into kubernetes:release-1.10 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas left review comments

@timothysc timothysc timothysc approved these changes

@dmmcquay dmmcquay Awaiting requested review from dmmcquay

Assignees

@timothysc timothysc

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chuckha @timothysc @k8s-github-robot @k8s-ci-robot @luxas @detiber