Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PST to main SECURITY_CONTACTS as formality #64262

Merged
merged 1 commit into from
Jun 1, 2018
Merged

add PST to main SECURITY_CONTACTS as formality #64262

merged 1 commit into from
Jun 1, 2018

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented May 24, 2018 •
edited

Add the Product Security Team as the security contacts for the main
repository and they can use the OWNERS files in each subsystem/dir to find
the correct owners.

cc @liggitt @cjcullen @tallclair @philips

NONE

closes #64265

Signed-off-by: Jess Frazelle acidburn@microsoft.com

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2018
@liggitt
Copy link
Member

liggitt commented May 24, 2018

can you copy this into the root of the staging/src/k8s.io/... dirs so it gets published out to those repos (this is the canonical source)

@jessfraz
Copy link
Contributor Author

jessfraz commented May 24, 2018 via email

@jessfraz
add PST to main SECURITY_CONTACTS as formality
ac01589 
Add the Product Security Team as the security contacts for the main
repository and they can use the OWNERS files in each subsystem/dir to find
the correct owners.

Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2018
@dims
Copy link
Member

dims commented May 25, 2018

/lgtm

@liggitt this looks ready

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2018
@sttts
Copy link
Contributor

sttts commented May 29, 2018

/approve

@jessfraz
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@jessfraz jessfraz added this to the v1.11 milestone May 30, 2018
@jessfraz jessfraz removed this from the v1.11 milestone May 30, 2018
@jessfraz
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@jessfraz
Copy link
Contributor Author

I have no idea why that test is failing...

@nikhita
Copy link
Member

nikhita commented May 30, 2018

I have no idea why that test is failing...

Looks like a really flaky test since the test failures are not consistent...

Hopefully, works this time :)
/retest

@jessfraz
Copy link
Contributor Author

omg its green do i need a specific milestone

@dims
Copy link
Member

dims commented May 30, 2018

/milestone v1.11
/priority important-soon

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 30, 2018
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 30, 2018
@bgrant0607
Copy link
Member

https://english.stackexchange.com/questions/88485/proper-timezone-acronym-usage-pt-vs-pdt-or-pst

@bgrant0607
Copy link
Member

Different PST. :-)

@bgrant0607
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, dims, jessfraz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2018
@nikhita
Copy link
Member

nikhita commented Jun 1, 2018

Still needs status/approved-for-milestone.

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bgrant0607 @dims @jessfraz

Pull Request Labels
  • sig/architecture sig/auth: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@bgrant0607
Copy link
Member

BTW, because these files don't end in .md (or .txt or any suffix), they unnecessarily require the full testsuite pre- and post-submit. Either they should be exempted, like READMEs and OWNERS, or add suffix to put in the exempted class. SIG Testing should be able to help with that.

Hopefully these specific won't change often, but if others copy the pattern, it could lead to problems.

@jessfraz
Copy link
Contributor Author

jessfraz commented Jun 1, 2018

Good to know I'll follow up on that, thanks

@nikhita nikhita mentioned this pull request Jun 1, 2018
Merged
@nikhita
Copy link
Member

nikhita commented Jun 1, 2018

@bgrant0607 @jessfraz created kubernetes/test-infra#8207 :)

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5da925a into kubernetes:master Jun 1, 2018
@jessfraz jessfraz deleted the SECURITY_CONTACTS branch June 1, 2018 21:24
This was referenced Jun 2, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbeda jbeda Awaiting requested review from jbeda

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Create a SECURITY_CONTACTS file.
9 participants
@jessfraz @liggitt @dims @sttts @nikhita @bgrant0607 @k8s-ci-robot @k8s-github-robot @cblecker