client-go: promote exec plugin support to beta #64482

ericchiang · 2018-05-29T22:13:35Z

/sig auth
/kind feature

Adds a "v1beta1" API group for client authentication. Because of a lack of usage with the input parameters, these have been dropped for the beta. Would like to re-introduce them as users feel they require them.

updates #61796

client-go: credential exec plugins have been promoted to beta

ericchiang · 2018-05-30T00:36:25Z

/test pull-kubernetes-kubemark-e2e-gce

ericchiang · 2018-05-30T19:45:23Z

Going to let #61803 merge first.

ericchiang · 2018-05-30T19:45:50Z

/sig auth
/kind feature
/milestone v1.11
/priority important-longterm
/status approved-for-milestone

ericchiang · 2018-05-31T21:52:42Z

/test pull-kubernetes-bazel-build

dims · 2018-06-01T16:57:56Z

/assign @thockin

ericchiang · 2018-06-01T17:37:42Z

cc @kubernetes/sig-auth-pr-reviews

php-coder · 2018-06-01T17:42:53Z

staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec_test.go

@@ -420,6 +486,13 @@ func TestRefreshCreds(t *testing.T) {
 				t.Errorf("expected expiry %v got %v", test.wantExpiry, a.exp)
 			}

+			if test.wantInput == "" {
+				if got := strings.TrimSpace(stderr.String()); got != "" {
+					t.Errorf("expectd no input parameters, got %q", got)


s/expectd/expected/

thanks! updated

awly · 2018-06-01T18:57:39Z

staging/src/k8s.io/client-go/pkg/apis/clientauthentication/v1beta1/types.go

+
+// Response defines metadata about a failed request, including HTTP status code and
+// response headers.
+type Response struct {


Can this be removed?

Yep. thanks for pointing that out

./hack/update-bazel.sh ./hack/update-codegen.sh ./hack/update-staging-godeps.sh

awly · 2018-06-01T21:40:19Z

/lgtm

ericchiang · 2018-06-01T22:42:07Z

/assign @thockin

For final approval

k8s-github-robot · 2018-06-01T22:42:53Z

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@awly @ericchiang @liggitt @thockin

Pull Request Labels

sig/auth: Pull Request will be escalated to these SIGs if needed.
priority/important-longterm: Escalate to the pull request owners; move out of the milestone after 1 attempt.
kind/feature: New functionality.

Help

thockin · 2018-06-04T21:43:19Z

I have no context on this API, so it's hard for me to review. Given that it is mostly empty, I guess it's not a big deal yet :)

/approve

k8s-ci-robot · 2018-06-04T21:43:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awly, ericchiang, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/OWNERS~~ [thockin]
~~staging/src/k8s.io/apiextensions-apiserver/Godeps/OWNERS~~ [thockin]
~~staging/src/k8s.io/apiserver/Godeps/OWNERS~~ [thockin]
~~staging/src/k8s.io/client-go/OWNERS~~ [thockin]
~~staging/src/k8s.io/kube-aggregator/Godeps/OWNERS~~ [thockin]
~~staging/src/k8s.io/metrics/Godeps/OWNERS~~ [thockin]
~~staging/src/k8s.io/sample-apiserver/Godeps/OWNERS~~ [thockin]
~~staging/src/k8s.io/sample-controller/Godeps/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot · 2018-06-04T23:56:13Z

Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions here.

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes versions v1.16 through v1.21. This is a breaking change for clients running versions v1.10 and older, which haven't been supported by EKS since September 2019. Signed-off-by: Micah Hausler <mhausler@amazon.com>

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482). At the time of this commit, community-supported versions are v1.19, v1.20, v1.21. This change will break for Kubernetes clients using client-go or kubectl v1.10 and earlier, which reached end-of-life community support on Feb 13, 2019. EKS ended support for 1.10 in September of 2019. Kubernetes 1.22 will introduce v1 of this API, but v1beta1 will likely be supported for a period of 2 more years. Signed-off-by: Micah Hausler <mhausler@amazon.com>

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes versions v1.16 through v1.21. This is a breaking change for clients running versions v1.10 and older, which haven't been supported by EKS since September 2019. Signed-off-by: Micah Hausler <mhausler@amazon.com>

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes versions v1.16 through v1.21. This is a breaking change for clients running versions v1.10 and older, which haven't been supported by EKS since September 2019. "aws eks get-token" now respects the KUBERNETES_EXEC_INFO environment variable and conservatively falls back to v1alpha1, which is supported by Kubernetes versions 1.10 through 1.22 (released upstream August 2021, to be released by EKS in Q4 2021). It also now supports "v1beta1" and "v1". "aws eks update-kubeconfig" now writes "v1beta1" in the kubeconfig which will be supported by Kubernetes until 1.29 (aproximately December 2023). At or around that date, we can change the default version written to kubeconfigs to "v1" Signed-off-by: Micah Hausler <mhausler@amazon.com>

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes versions v1.16 through v1.21. This is a breaking change for clients running versions v1.10 and older, which haven't been supported by EKS since September 2019. Signed-off-by: Micah Hausler <mhausler@amazon.com>

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes versions v1.16 through v1.21. This is a breaking change for clients running versions v1.10 and older, which haven't been supported by EKS since September 2019. "aws eks get-token" now respects the KUBERNETES_EXEC_INFO environment variable and conservatively falls back to v1alpha1, which is supported by Kubernetes versions 1.10 through 1.22 (released upstream August 2021, to be released by EKS in Q4 2021). It also now supports "v1beta1" and "v1". "aws eks update-kubeconfig" now writes "v1beta1" in the kubeconfig which will be supported by Kubernetes until 1.29 (aproximately December 2023). At or around that date, we can change the default version written to kubeconfigs to "v1" Signed-off-by: Micah Hausler <mhausler@amazon.com>

k8s-ci-robot requested review from caesarxuchao and yliaog May 29, 2018 22:13

ericchiang changed the title ~~Exec plugin beta~~ client-go: promote exec plugin support to beta May 29, 2018

ericchiang force-pushed the exec-plugin-beta branch 3 times, most recently from 10849c4 to d3b16da Compare May 29, 2018 23:40

ericchiang added this to the v1.11 milestone May 30, 2018

k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. status/approved-for-milestone labels May 30, 2018

ericchiang force-pushed the exec-plugin-beta branch from d3b16da to 443bfdb Compare May 31, 2018 21:40

k8s-ci-robot assigned thockin Jun 1, 2018

ericchiang assigned liggitt and awly and unassigned thockin Jun 1, 2018

php-coder reviewed Jun 1, 2018

View reviewed changes

ericchiang force-pushed the exec-plugin-beta branch from d21d289 to d6cee21 Compare June 1, 2018 17:50

awly reviewed Jun 1, 2018

View reviewed changes

ericchiang added 2 commits June 1, 2018 14:27

clientauthentication: add v1beta1 API version

8952b8f

client-go: promote exec plugin support to beta

0a9164e

ericchiang added 2 commits June 1, 2018 14:28

generated:

2069827

./hack/update-bazel.sh ./hack/update-codegen.sh ./hack/update-staging-godeps.sh

client-go: make exec auth and auth provider mutually exclusive

d96fd39

ericchiang force-pushed the exec-plugin-beta branch from d6cee21 to d96fd39 Compare June 1, 2018 21:29

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018

k8s-ci-robot assigned thockin Jun 1, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2018

k8s-github-robot merged commit 819d515 into kubernetes:master Jun 4, 2018

ericchiang mentioned this pull request Jun 5, 2018

client-go credential providers 1.11 umbrella issue #61796

Closed

3 tasks

ericchiang mentioned this pull request Jul 31, 2018

External client-go credential providers kubernetes/enhancements#541

Closed

ikorolev93 mentioned this pull request Nov 13, 2019

exec plugin: invalid apiVersion "client.authentication.k8s.io/v1beta1" splunk/qbec#83

Closed

micahhausler mentioned this pull request Jul 21, 2021

[customizations/eks]: Update credential API version aws/aws-cli#6289

Merged

micahhausler mentioned this pull request Jul 21, 2021

[pkg/token]: Update credential API version kubernetes-sigs/aws-iam-authenticator#386

Merged

micahhausler mentioned this pull request Oct 13, 2021

Deprecate Kubernetes client API version v1alpha1 aws/aws-cli#6476

Merged

z0rc mentioned this pull request May 18, 2022

Support KUBERNETES_EXEC_INFO for kube_exec_auth cloudposse/terraform-aws-eks-cluster#131

Closed

karlderkaefer mentioned this pull request Jun 21, 2022

Deprecated client authentication v1alpha1 signavio/aws-mfa-login#56

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client-go: promote exec plugin support to beta #64482

client-go: promote exec plugin support to beta #64482

ericchiang commented May 29, 2018 •

edited

ericchiang commented May 30, 2018

ericchiang commented May 30, 2018

ericchiang commented May 30, 2018

ericchiang commented May 31, 2018

dims commented Jun 1, 2018

ericchiang commented Jun 1, 2018

php-coder Jun 1, 2018

ericchiang Jun 1, 2018

awly Jun 1, 2018

ericchiang Jun 1, 2018

awly commented Jun 1, 2018

ericchiang commented Jun 1, 2018

k8s-github-robot commented Jun 1, 2018

thockin commented Jun 4, 2018

k8s-ci-robot commented Jun 4, 2018

k8s-github-robot commented Jun 4, 2018

client-go: promote exec plugin support to beta #64482

client-go: promote exec plugin support to beta #64482

Conversation

ericchiang commented May 29, 2018 • edited

ericchiang commented May 30, 2018

ericchiang commented May 30, 2018

ericchiang commented May 30, 2018

ericchiang commented May 31, 2018

dims commented Jun 1, 2018

ericchiang commented Jun 1, 2018

php-coder Jun 1, 2018

Choose a reason for hiding this comment

ericchiang Jun 1, 2018

Choose a reason for hiding this comment

awly Jun 1, 2018

Choose a reason for hiding this comment

ericchiang Jun 1, 2018

Choose a reason for hiding this comment

awly commented Jun 1, 2018

ericchiang commented Jun 1, 2018

k8s-github-robot commented Jun 1, 2018

thockin commented Jun 4, 2018

k8s-ci-robot commented Jun 4, 2018

k8s-github-robot commented Jun 4, 2018

ericchiang commented May 29, 2018 •

edited