-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add debugging for aggregator flake #64587
Conversation
Thanks! this is really helpful, that test doesn't really output very much which is making it pretty hard to debug.
We might also need to get the logs from the pod that is running the sample-apiserver even if it doesn't fail. From the logs I saw it looked like it wasn't failing, just taking a long time (or forever) to start the server. Not sure how possible that is to do, though. |
that would cause a timeout failure, which this should capture |
ah I see you were saying if the test failed, not if the pod failed. My mistake. Are you going to just keep retesting this until it flakes? |
since it only kicks in when the test fails, I'd probably merge this to get data from CI runs |
/retest |
/assign @jennybuckley @cheftako |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jennybuckley, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.11 |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process @cheftako @jennybuckley @liggitt Pull Request Labels
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
capture current state of the APIService and extension server pod for output in failure cases
xref #63622