Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collecting etcd metrics #64695

Merged
merged 1 commit into from Jul 10, 2018
Merged

Collecting etcd metrics #64695

merged 1 commit into from Jul 10, 2018

Conversation

krzysied
Copy link
Contributor

@krzysied krzysied commented Jun 4, 2018 •
edited

What this PR does / why we need it:
Adding etcd metrics to performance test log.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
ref #64030

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2018
@krzysied
Copy link
Contributor Author

krzysied commented Jun 4, 2018

/assign shyamjvs

@krzysied
Copy link
Contributor Author

krzysied commented Jun 4, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2018
@shyamjvs
Copy link
Member

shyamjvs commented Jun 4, 2018

@krzysied Let's not mark the issue as fixed in the PR description - as there are more parts to it (e.g perfdash).

shyamjvs
shyamjvs reviewed Jun 4, 2018
View reviewed changes
test/e2e/framework/metrics_util.go Outdated
}
}

func (h *histogram) CalculatePercs() (float64, float64, float64) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead make this a function that takes single argument (like 0.5, 0.9, etc) and returns a single value for the percentile value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@timothysc timothysc removed their request for review June 4, 2018 15:32
@krzysied
Copy link
Contributor Author

krzysied commented Jun 4, 2018

/retest

@krzysied
Copy link
Contributor Author

krzysied commented Jun 6, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2018
@shyamjvs
Copy link
Member

shyamjvs commented Jul 6, 2018

/lgtm
/hold
@wojtek-t @jpbetz - In case you may have some comments (note that this is an initial attempt to start collecting few basic but useful metrics).
We have the metrics available as histograms, but the reason why I asked for conversion to percentiles is so we can better visualize on our perf dashboard.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2018
@krzysied
Copy link
Contributor Author

krzysied commented Jul 9, 2018

/retest

@shyamjvs
Copy link
Member

/hold cancel

As no comments were raised.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@krzysied
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64695, 65982, 65908). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a8777c2 into kubernetes:master Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

@krzysied: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws aa02231 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jpbetz
Copy link
Contributor

jpbetz commented Jul 10, 2018

/cc @wenjiaswe

@k8s-ci-robot
Copy link
Contributor

@jpbetz: GitHub didn't allow me to request PR reviews from the following users: wenjiaswe.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wenjiaswe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shyamjvs shyamjvs mentioned this pull request Jul 11, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjvs shyamjvs shyamjvs left review comments

@enisoc enisoc Awaiting requested review from enisoc

Assignees

@shyamjvs shyamjvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@krzysied @shyamjvs @k8s-ci-robot @k8s-github-robot @jpbetz