Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test tag on dynamic config tests #64705

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Fix test tag on dynamic config tests #64705

merged 1 commit into from
Jun 5, 2018

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Jun 4, 2018

The test accidentally got turned off when the NodeAlphaFeature tag was
added in #64125. This PR updates the tag to turn it back on.

NONE

@mtaufen
Fix test tag on dynamic config tests
0a6db6b 
The test accidentally got turned off when the NodeAlphaFeature tag was
added in kubernetes#64125. This PR updates the tag to turn it back on.
@mtaufen mtaufen added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. status/approved-for-milestone labels Jun 4, 2018
@mtaufen mtaufen added this to the v1.11 milestone Jun 4, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2018
@Random-Liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2018
@yujuhong
Copy link
Contributor

yujuhong commented Jun 4, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtaufen
Copy link
Contributor Author

mtaufen commented Jun 4, 2018

/retest

1 similar comment
@dims
Copy link
Member

dims commented Jun 4, 2018

/retest

@jberkus
Copy link

jberkus commented Jun 5, 2018

Needs a kind label:

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 5, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@Random-Liu @mtaufen @yujuhong

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5b9db83 into kubernetes:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer approved these changes

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mtaufen @Random-Liu @yujuhong @k8s-ci-robot @dims @jberkus @k8s-github-robot @resouer