-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreDNS to use gcr.io repo #64775
CoreDNS to use gcr.io repo #64775
Conversation
Opening this PR which makes the same changes as #59753. The original author of the PR @nashasha1 doesn't seem to be active and wanted to make sure that these changes get in before code freeze. |
/milestone v1.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
kind/cleanup |
priority/important-soon |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luxas, rajansandeep, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/status approved-for-milestone |
@roberthbailey @luxas thank you for the quick response!! |
/test pull-kubernetes-integration |
FYI: This PR is not marked as priority/critical-urgent. As such, it will be removed from the 1.11 milestone by the milestone bot when Code Freeze starts at midnight UTC / 5pm PDT. If you feel it is critical to 1.11, please upgrade its priority to critical-urgent. |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process @luxas @rajansandeep @roberthbailey Pull Request Labels
|
@tpepper - I've been watching this PR today; it's currently in the batch submit being tested. If it doesn't merge before the code freeze I'll update the labels, since we do want it to make the release cut. --edit-- It looks like @timothysc already updated the labels. |
Automatic merge from submit-queue (batch tested with PRs 63322, 64718, 64708, 64775, 64777). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Switch CoreDNS to use the gcr.io in kubeadm
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: