Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremented the elasticsearch version #65919

Merged
merged 1 commit into from Jul 10, 2018
Merged

Incremented the elasticsearch version #65919

merged 1 commit into from Jul 10, 2018

Conversation

IvanovOleg
Copy link
Contributor

@IvanovOleg IvanovOleg commented Jul 6, 2018 •
edited

What this PR does / why we need it:
Applies changes implemented in:
#65627

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2018
@neolit123
Copy link
Member

/cc @kubernetes/sig-instrumentation-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jul 7, 2018
@coffeepac
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2018
@coffeepac
Copy link
Contributor

@IvanovOleg would prefer a release note of NONE . no need for this to show up in the 1.12 release notes

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2018
@IvanovOleg
Copy link
Contributor Author

/retest

@IvanovOleg
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@coffeepac
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, IvanovOleg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65794, 65919). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f682299 into kubernetes:master Jul 10, 2018
@IvanovOleg
Copy link
Contributor Author

kubelet, stg-orion-k8s-agentpool1-2 Failed to pull image "k8s.gcr.io/elasticsearch:v6.2.5": rpc error: code = Unknown desc = failed to resolve image "k8s.gcr.io/elasticsearch:v6.2.5": k8s.gcr.io/elasticsearch:v6.2.5 not found
It looks like somebody should build it.

@IvanovOleg
Copy link
Contributor Author

Is anybody going to build this image?

@loburm
Copy link
Contributor

loburm commented Jul 16, 2018

I'll build it, but next time we shouldn't bump version in the Makefile and in manifests file at the same file. Because otherwise we are going to have build in not healthy state.

@loburm
Copy link
Contributor

loburm commented Jul 17, 2018

Image should be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeepac coffeepac Awaiting requested review from coffeepac

@piosz piosz Awaiting requested review from piosz

Assignees

@coffeepac coffeepac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@IvanovOleg @neolit123 @coffeepac @k8s-ci-robot @k8s-github-robot @loburm