Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure-helper.sh to support heapster resource optimizations #66185

Merged
merged 4 commits into from
Aug 15, 2018
Merged

Update configure-helper.sh to support heapster resource optimizations #66185

merged 4 commits into from
Aug 15, 2018

Conversation

vantuvt
Copy link
Contributor

@vantuvt vantuvt commented Jul 14, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2018
@vantuvt
Copy link
Contributor Author

vantuvt commented Jul 17, 2018

/assign @gmarek

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2018
@vantuvt
Update configure-helper.sh to support heapster resource optimizations
2bce0cb 
In addition to the shell script changes the heapster yaml has been
updated to use addon resizer 1.8.3 for the heapster-nanny. Addon resizer 1.8.3
is being used to take advantage of the new minClusterSize flag. Note this is a
no-op change. The values specified for heapster-nanny reflect the current
configuration used with version 1.8.2.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 22, 2018
@dims
Copy link
Member

dims commented Jul 31, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2018
@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 7, 2018

/retest

@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 7, 2018

/test pull-kubernetes-e2e-kops-aws

gmarek
gmarek reviewed Aug 8, 2018
View reviewed changes
cluster/gce/gci/configure-helper.sh Outdated
local -r metrics_cpu_per_node="${HEAPSTER_GCP_CPU_PER_NODE:-0.5}"
local -r eventer_memory_per_node="500"
local -r nanny_memory_per_node="200"
if [[ "${ENABLE_SYSTEM_ADDON_RESOURCE_OPTIMIZATIONS:-}" == "true" ]]; then
# TODO: Set each of the following variables to optimized values.
base_metrics_memory="140Mi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably wanted "${HEAPSTER_GCP_BASE_MEMORY:-140Mi}". I'd drop this 'if' as it's a no-op. It's easy enough to add when you'll have the proper logic figured out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks. This logic has been implemented to facilitate testing of a complementary change that sets the ENABLE_SYSTEM_ADDON_RESOURCE_OPTIMIZATIONS environment variable.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2018
@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 10, 2018

I've updated this PR with the final scaling policy numbers. So the TODO I had originally added has now been cleaned up. PTAL. Thanks!

@piosz piosz self-assigned this Aug 13, 2018
@piosz
Copy link
Member

piosz commented Aug 13, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 13, 2018

/assign @yguo0905

@yguo0905
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piosz, vantuvt, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 14, 2018 via email

@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 14, 2018 via email

@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 14, 2018 via email

@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 14, 2018 via email

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66177, 66185, 67136, 67157, 65065). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 803e96e into kubernetes:master Aug 15, 2018
@k8s-ci-robot
Copy link
Contributor

@vantuvt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 5d191d8 link /test pull-kubernetes-integration
pull-kubernetes-e2e-gke 5d191d8 link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vantuvt
Copy link
Contributor Author

vantuvt commented Aug 15, 2018

/retest

@vantuvt vantuvt deleted the vantuvt-patch-3 branch August 16, 2018 14:43
@vantuvt vantuvt mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek gmarek left review comments

Assignees

@gmarek gmarek

@piosz piosz

@yguo0905 yguo0905

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vantuvt @dims @piosz @yguo0905 @k8s-ci-robot @k8s-github-robot @gmarek