Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #66264: extend timeout to workaround slow arm64 math #66459

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Automated cherry pick of #66264: extend timeout to workaround slow arm64 math #66459

merged 1 commit into from
Jul 25, 2018

Conversation

joejulian
Copy link
Contributor

Cherry pick of #66264 on release-1.10.

#66264: extend timeout to workaround slow arm64 math

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2018
@joejulian
extend timeout to workaround slow arm64 math
05876fa 
The math/big functions are slow on arm64. There is improvement coming
with go1.11 but in the mean time if a server uses rsa certificates on
arm64, the math load for the multitude of watches over taxes the ability
of the processor and the TLS connections time out. Retries will also not
succeed and serve to exacerbate the problem.

By extending the timeout, the TLS connections will eventually be
successful and the load will drop.

Fixes kubernetes#64649
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 20, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2018
@timothysc timothysc added this to the v1.10 milestone Jul 20, 2018
@timothysc timothysc added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. status/approved-for-milestone and removed milestone/incomplete-labels labels Jul 20, 2018
@timothysc
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2018
@timothysc
Copy link
Member

@kubernetes/release-maintainers - per cherry-pick

@joejulian
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 20, 2018
@joejulian
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@guineveresaenger
Copy link
Contributor

@foxish for cherry-pick approval

@joejulian
Copy link
Contributor Author

/assign @timothysc

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@joejulian @timothysc

Pull Request Labels
  • sig/api-machinery: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@guineveresaenger
Copy link
Contributor

oh whoops - Caleb is branch manager for 1.10
/cc @calebamiles

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2018
timothysc
timothysc approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joejulian, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2018
@guineveresaenger
Copy link
Contributor

And I picked the wrong person again. The cherrypicks doc needs updating.

/cc @MaciekPytel

@MaciekPytel
Copy link
Contributor

Looks good, but this cherry-pick was opened past deadline for 1.10.6. Currently I'm only cherry-picking PRs that fix release-blocking tests, so we can get the release going. Please ping me if you think this is critical for 1.10.6, otherwise I'll merge it after the release.

@joejulian
Copy link
Contributor Author

If we were testing on multiple architectures this would be a critical failure. This prevents kube-apiserver from running on arm64 processors.

Based on the numerous "thank you" messages I received when I found this solution, this appears to be affecting more than a handful of users.

@MaciekPytel
Copy link
Contributor

Discussed with @joejulian offline and it looks quite urgent. I'll merge this PR after the tests recover, unless it would cause significant delay to 1.10.6 relase.

@timothysc timothysc added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 24, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 25, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a21fdbd into kubernetes:release-1.10 Jul 25, 2018
@joejulian joejulian deleted the automated-cherry-pick-of-#66264-upstream-release-1.10 branch July 25, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@calebamiles calebamiles Awaiting requested review from calebamiles

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@timothysc timothysc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joejulian @timothysc @guineveresaenger @k8s-github-robot @k8s-ci-robot @MaciekPytel