Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update container resources reference link #67307

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Update container resources reference link #67307

merged 2 commits into from
Aug 15, 2018

Conversation

jlegrone
Copy link
Contributor

What this PR does / why we need it:
Users are currently directed to documentation on PersistentVolumeClaim resources when looking for information on Container resources. While this field is backed by the same type in both instances, Managing Compute Resources for Containers is more relevant in the Container context.

This is surfaced in at least two places:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2018
@jlegrone
Copy link
Contributor Author

/assign @mistyhacks

@jlegrone
Copy link
Contributor Author

/assign @thockin

@nikhita
Copy link
Member

nikhita commented Aug 13, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 13, 2018
@jlegrone jlegrone force-pushed the feature/update-container-resources-ref branch from 6cc511a to 42a79e0 Compare August 13, 2018 18:26
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2018
@jlegrone
Update Container Resources more info link
74c1dee
@jlegrone
Autogen
2b3621a 
1. hack/update-generated-protobuf.sh
2. hack/update-generated-swagger-docs.sh
3. hack/update-swagger-spec.sh
4. hack/update-openapi-spec.sh
5. hack/update-api-reference-docs.sh
@jlegrone jlegrone force-pushed the feature/update-container-resources-ref branch from 42a79e0 to 2b3621a Compare August 13, 2018 18:58
@jlegrone
Copy link
Contributor Author

/retest

@thockin
Copy link
Member

thockin commented Aug 13, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2018
@mdlinville
Copy link

/lgtm

I'm not an approver in this repo.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlegrone, mistyhacks, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@jlegrone
Copy link
Contributor Author

/retest

1 similar comment
@krzyzacy
Copy link
Member

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67347, 67307, 67358, 67364, 67385). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 93ae5d2 into kubernetes:master Aug 15, 2018
@jlegrone jlegrone deleted the feature/update-container-resources-ref branch August 15, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@thockin thockin

@mdlinville mdlinville

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jlegrone @nikhita @thockin @mdlinville @k8s-ci-robot @fejta-bot @krzyzacy @k8s-github-robot