-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete the busyboxImage and mountTest var and change use imageutils #67364
Conversation
/approve |
/ok-to-test |
/test pull-kubernetes-e2e-kops-aws |
1 similar comment
/test pull-kubernetes-e2e-kops-aws |
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
/test pull-kubernetes-e2e-kops-aws |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like what was asked for was done.
no var referenced, direct calls to imageutils everywhere.
/lgtm cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, MHBauer, mikedanese, thdrnsdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Automatic merge from submit-queue (batch tested with PRs 67347, 67307, 67358, 67364, 67385). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
delete the
busyboxImage
,mountTest
variable and change everything to useimageutils.GetE2EImage(imageutils.BusyBox)
,imageutils.GetE2EImage(imageutils.MountTest)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #67237
Special notes for your reviewer:
/cc @mikedanese
/assign @mikedanese
Release note: