Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Add ListLocations to Cloud TPU API #67917

Merged
merged 1 commit into from
Aug 28, 2018
Merged

GCE: Add ListLocations to Cloud TPU API #67917

merged 1 commit into from
Aug 28, 2018

Conversation

yguo0905
Copy link
Contributor

Add ListLocations to Cloud TPU API.

Release note:

None

/assign @vishh
/assign @MrHohn
for approval.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 28, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2018
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2018
@vishh
Copy link
Contributor

vishh commented Aug 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2018
@yguo0905 yguo0905 mentioned this pull request Aug 28, 2018
Merged
MrHohn
MrHohn approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

MrHohn
MrHohn approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, vishh, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2018
@dims
Copy link
Member

dims commented Aug 28, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims August 28, 2018 01:48
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64597, 67854, 67734, 67917, 67688). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8c9f145 into kubernetes:master Aug 28, 2018
@foxish foxish added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Aug 28, 2018
k8s-github-robot pushed a commit that referenced this pull request Aug 28, 2018
Merge pull request #67918 from yguo0905/automated-cherry-pick-of-#679…
e3473ab 
…17-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #67917: GCE: Add ListLocations to Cloud TPU API

Cherry pick of #67917 on release-1.11.

#67917: GCE: Add ListLocations to Cloud TPU API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@vishh vishh

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yguo0905 @vishh @k8s-ci-robot @dims @k8s-github-robot @MrHohn @foxish