E2E tests for DynamicProvisioningScheduling support for GCE PD and RePD #67963
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
sig/testing
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
test/e2e/storage/regional_pd.go
Outdated
| if !zoneFound { | ||
| framework.Failf("zones specified in AllowedTopologies: %v does not contain zone of node where PV got provisioned: %s", topoZones, nodeZone) | ||
| } | ||
| checkZoneFromLabelAndAffinity(pv, nodeZone, false) |
There was a problem hiding this comment.
should this check that both zones were specified?
There was a problem hiding this comment.
Indeed. Thanks for catching this. I have tightened the check.
|
/assign @rootfs |
|
lgtm, please squash |
Signed-off-by: Deep Debroy <ddebroy@docker.com>
|
squashed commits so far |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddebroy, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/milestone v1.12 |
|
@ddebroy: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/retest |
|
/test pull-kubernetes-e2e-gce |
|
/test pull-kubernetes-e2e-kops-aws |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. |
What this PR does / why we need it:
Add end2end tests to exercise DynamicProvisioningScheduling features for GCE PD and RePD. The tests make sure WaitForFirstConsumer and AllowedTopologies specified in a GCE PD/RePD storage class has the desired effect.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Tests features added in a2de7d2
Release note:
/sig storage
cc @msau42