Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #63003: Fix scheduler informers to receive events for all the pods in the cluster #67994

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Automated cherry pick of #63003: Fix scheduler informers to receive events for all the pods in the cluster #67994

merged 2 commits into from
Aug 31, 2018

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Aug 29, 2018

Cherry pick of #63003 on release-1.9.

#63003: Added test for scheduler informers

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2018
@cofyc
Copy link
Member Author

cofyc commented Aug 29, 2018

/assign @mbohlool
/assign @bsalamat for approval

@k8s-ci-robot
Copy link
Contributor

@cofyc: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @mbohlool
/assign @bsalamat for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cofyc cofyc mentioned this pull request Aug 29, 2018
Merged
@cofyc cofyc force-pushed the automated-cherry-pick-of-#63003-upstream-release-1.9 branch from c87cd70 to 13ef25d Compare August 29, 2018 09:25
@cofyc cofyc force-pushed the automated-cherry-pick-of-#63003-upstream-release-1.9 branch from 13ef25d to 8abe87b Compare August 29, 2018 09:37
@cofyc
Copy link
Member Author

cofyc commented Aug 29, 2018

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-kops-aws

bsalamat
bsalamat approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this PR is misleading. We are backporting a bug fix, not just the tests. You may want to change the title and use the same title as the original PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, cofyc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@bsalamat
Copy link
Member

We should also cherrypick this into 1.10.

@bsalamat bsalamat added this to the v1.9 milestone Aug 29, 2018
@cofyc cofyc changed the title Automated cherry pick of #63003: Added test for scheduler informers Automated cherry pick of #63003: Fix scheduler informers to receive events for all the pods in the cluster Aug 30, 2018
@cofyc
Copy link
Member Author

cofyc commented Aug 30, 2018

@bsalamat Title is updated.

@cofyc
Copy link
Member Author

cofyc commented Aug 30, 2018

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-kops-aws

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 31, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit d4e482c into kubernetes:release-1.9 Aug 31, 2018
@houz42 houz42 mentioned this pull request Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@mbohlool mbohlool

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cofyc @k8s-ci-robot @bsalamat @k8s-github-robot @mbohlool