-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subpath tests not to fail in namespace deletion #68074
Conversation
This commit fixes below subpath test not to fail in namespace deletion - subPath should support restarting containers using directory as subpath - subPath should support restarting containers using file as subpath Fixes: kubernetes#68073
PTAL |
/ok-to-test |
/assign @msau42 |
/test pull-kubernetes-e2e-gce |
/milestone v1.12 |
/lgtm This is fine for quickly fixing the release blocking tests. Let's still investigate why the AfterEach cleanup is not working. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkimuram, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I looked up the error message we're seeing and found in the code:
meaning the pods already had deletion timestamp but they were not deleted in time. |
That's from the namespace deletion that happens at the very end of the tests. But in the case of nfs and gluster, where the storage backends are pods themselves, this is too late because the storage backend pods get deleted at the end of the test. So if the client Pod gets deleted after the storage backend Pod, then the client Pod deletion will hang forever. |
Automatic merge from submit-queue (batch tested with PRs 67368, 59930, 68074). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. |
I confirmed that after #68569 is applied, even deleting this commit doesn't make error. Although this commit isn't necessarily needed now, but it isn't harmful and is consistent with other test functions. Therefore, I think that we can keep this commit as it is. I think that we can regard that issue #68073 is now resolved completely. |
What this PR does / why we need it:
This PR fixes below subpath test not to fail in namespace deletion
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes: #68073
Special notes for your reviewer:
/sig storage
/sig testing
Release note: