-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused format log print #68264
Conversation
IMO, the format is OK. |
/shrug |
/cc @nikhita |
/uncc |
/approve will let @nikhita apply the lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, nikhita, tanshanshan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
…On Wed, Oct 3, 2018 at 2:07 PM k8s-ci-robot ***@***.***> wrote:
@tanshanshan <https://github.com/tanshanshan>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration f6da98c
<f6da98c>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68264/pull-kubernetes-integration/29630/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/68264>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/tanshanshan>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#68264 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0EelNZWQQehGarmW-0_4jgPIjE_wks5uhHdcgaJpZM4WaHFx>
.
|
/retest
…On Wed, Oct 3, 2018 at 2:28 PM k8s-ci-robot ***@***.***> wrote:
@tanshanshan <https://github.com/tanshanshan>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration f6da98c
<f6da98c>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68264/pull-kubernetes-integration/29639/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/68264>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/tanshanshan>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#68264 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0DntVHJfoVXzSMYJYdzocwoSj_fcks5uhHxSgaJpZM4WaHFx>
.
|
/retest Review the full test history for this PR. Silence the bot with an |
/retest
…On Wed, Oct 3, 2018 at 6:32 PM k8s-ci-robot ***@***.***> wrote:
@tanshanshan <https://github.com/tanshanshan>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance f6da98c
<f6da98c>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68264/pull-kubernetes-e2e-gce-100-performance/21873/> /test
pull-kubernetes-e2e-gce-100-performance
Full PR test history <https://k8s-gubernator.appspot.com/pr/68264>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/tanshanshan>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#68264 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0Eg4jyOjQ8d0TMkxDTiV0_WzgruUks5uhLVzgaJpZM4WaHFx>
.
|
What this PR does / why we need it:
remove unused format log print
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: