Add log-level mount option support for glusterfs plugin
#68440
Conversation
|
@humblec: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
/assign @wongma7 |
pkg/volume/glusterfs/glusterfs.go
Outdated
| @@ -323,7 +330,10 @@ func (b *glusterfsMounter) setUpAtInternal(dir string) error { | |||
|
|
|||
| // Use derived/provided log file in gluster fuse mount | |||
| options = append(options, "log-file="+log) | |||
There was a problem hiding this comment.
if hasLogFile = false, then log := "", should we append "log-file="+log to options?
There was a problem hiding this comment.
@linyouchong #68435 should address it.
There was a problem hiding this comment.
@linyouchong did that answer ? or the query was different ? :)
There was a problem hiding this comment.
@linyouchong #68435 should address it.
lgtm
|
@jingxu97 Can you please review this ? |
|
/assign @jsafrane |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@humblec , Looks like needs to add the release note or tag release-note-none. |
|
/release-note-none |
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
removed
the
needs-kind
|
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/retest Review the full test history for this PR. Silence the bot with an |
k8s-ci-robot
added
the
needs-rebase
The glusterfs plugin/driver set log-level to ERROR by default while
mounting glusterfs shares. However at times, its required to supply other
log-level options like INFO, TRACE..etc. This patch enables the support
to provide other log-level values from storageclass.
Additional Ref#
https://docs.gluster.org/en/v3/Administrator%20Guide/Setting%20Up%20Clients/
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
k8s-ci-robot
removed
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/retest
…On Wed, Oct 3, 2018 at 7:44 PM k8s-ci-robot ***@***.***> wrote:
@humblec <https://github.com/humblec>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration fdcd58a
<fdcd58a>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68440/pull-kubernetes-integration/29677/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/68440>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/humblec>. Please help
us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#68440 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0Ok2lkYs3jt9aLZKpNa5yNY-3pHpks5uhMZSgaJpZM4WgK2K>
.
|
|
@jsafrane Could you please bring back lgtm here ? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Review the full test history for this PR. Silence the bot with an |
The glusterfs plugin/driver set log-level to ERROR by default while
mounting glusterfs shares. However at times, its required to supply other
log-level options like INFO, TRACE..etc. This patch enables the support
to provide other log-level values from storageclass.
Additional Ref#
https://docs.gluster.org/en/v3/Administrator%20Guide/Setting%20Up%20Clients/
Signed-off-by: Humble Chirammal hchiramm@redhat.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: