Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore "not found" endpoint on deletion for Gluster Storage Test #68480

Merged
merged 1 commit into from Sep 11, 2018
Merged

Ignore "not found" endpoint on deletion for Gluster Storage Test #68480

merged 1 commit into from Sep 11, 2018

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Sep 10, 2018 •
edited

What this PR does / why we need it:
Ignores not found error when deleting Gluster endpoints

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68373

/sig storage
/kind bug
/assign @msau42

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 10, 2018
@davidz627
Copy link
Contributor Author

/assign @msau42

@davidz627 davidz627 changed the title Ignore "not found endpoint on deletion for Gluster Storage Test Ignore "not found" endpoint on deletion for Gluster Storage Test Sep 10, 2018
@msau42
Copy link
Member

msau42 commented Sep 10, 2018

/lgtm

other than bazel update

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2018
@davidz627
Copy link
Contributor Author

@msau42 updated bazel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2018
@msau42
Copy link
Member

msau42 commented Sep 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2018
@saad-ali
Copy link
Member

/approve

@saad-ali saad-ali added this to the v1.12 milestone Sep 10, 2018
@saad-ali saad-ali added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1ae00db into kubernetes:master Sep 11, 2018
@davidz627 davidz627 deleted the fix/glusterSubpathTest branch September 11, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffvance jeffvance Awaiting requested review from jeffvance

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
4 participants
@davidz627 @msau42 @saad-ali @k8s-ci-robot