Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delaying kubeclient and csi client injection into CSI plugin #68633

Merged
merged 1 commit into from Sep 13, 2018
Merged

Delaying kubeclient and csi client injection into CSI plugin #68633

merged 1 commit into from Sep 13, 2018

Conversation

verult
Copy link
Contributor

@verult verult commented Sep 13, 2018

What this PR does / why we need it:
Fixes #68509

Note for storage reviewers: the original flag gate check around CSI client initialization in Init() is covered inside nodeInfoManager calls and informer initialization in Init().

Release note:

NONE

/sig storage
/sig gcp
/assign @msau42 @saad-ali @AishSundar

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/gcp labels Sep 13, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2018
@verult
Copy link
Contributor Author

verult commented Sep 13, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 13, 2018
@AishSundar
Copy link
Contributor

/retest

@saad-ali saad-ali added this to the v1.12 milestone Sep 13, 2018
@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2018
@saad-ali
Copy link
Member

This is good for a short term fix. Longer term volume plugin initialization code should fail dependencies are nil. And the code triggering volume plugin initialization should determine if volume plugins are required and skip volume plugin initialization if volume plugins are not needed.

@verult
Copy link
Contributor Author

verult commented Sep 13, 2018

The PR changed the interface of NodeInfoManager, causing the unit test failures. Looking into it.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2018
@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018
@tpepper
Copy link
Member

tpepper commented Sep 13, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Sep 13, 2018
@tpepper
Copy link
Member

tpepper commented Sep 13, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

davidz627
davidz627 reviewed Sep 13, 2018
View reviewed changes
pkg/volume/csi/csi_plugin.go Outdated
p.csiDriverInformer = factory.Csi().V1alpha1().CSIDrivers()
p.csiDriverLister = p.csiDriverInformer.Lister()
go factory.Start(wait.NeverStop)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log something if client is nil?

dougm
dougm reviewed Sep 13, 2018
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watching for this to merge and will pull into release-1.12 via branchff once it has.

@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidz627
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 822739f into kubernetes:master Sep 13, 2018
@immutableT
Copy link
Contributor

This brakes kubelet in stand-alone mode; all gke tests are broken.

@saad-ali
Copy link
Member

This brakes kubelet in stand-alone mode; all gke tests are broken.

AFAIK, this PR fixed GKE tests which have been running without issue since it was merged: https://k8s-testgrid.appspot.com/google-gke#gci-gke

Following up with @immutableT offline to clarify.

@saad-ali
Copy link
Member

Following up with @immutableT offline to clarify.

Verified that @immutableT was running an older version, and with this fix the issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm left review comments

@davidz627 davidz627 davidz627 left review comments

@msau42 msau42 Awaiting requested review from msau42

Assignees

@saad-ali saad-ali

@AishSundar AishSundar

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@verult @AishSundar @saad-ali @tpepper @k8s-ci-robot @davidz627 @immutableT @dougm @msau42