Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a few typographic errors in test utils file #68903

Merged
merged 1 commit into from
Oct 8, 2018
Merged

fix a few typographic errors in test utils file #68903

merged 1 commit into from
Oct 8, 2018

Conversation

logicalhan
Copy link
Member

What this PR does / why we need it:

I was running some unit tests, noticed a typo and went ahead and audited the file.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2018
cheftako
cheftako reviewed Sep 20, 2018
View reviewed changes
Copy link
Member

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/controller/testutil/test_utils.go
@@ -304,7 +304,7 @@ func (m *FakeNodeHandler) Patch(name string, pt types.PatchType, data []byte, su
}
var originalNode v1.Node
if err = json.Unmarshal(originalObjJS, &originalNode); err != nil {
glog.Errorf("Failed to unmarshall original object: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this same mistake is on line 340.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated my commit to include that fix. Thanks for the extra eyes.

logicalhan
logicalhan commented Sep 20, 2018
View reviewed changes
Copy link
Member Author

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to include the typo that Walter pointed out.

@cheftako
Copy link
Member

/test

@cheftako
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 20, 2018
@cheftako
Copy link
Member

/test pull-kubernetes-integration

@logicalhan
Copy link
Member Author

/retest

cheftako
cheftako approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm. Thanks for fixing this.

@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

went ahead and audited the file.

@logicalhan Thanks for taking care of all loose ends!

/retest
/sig api-machinery
/kind cleanup

Re-applying @cheftako's lgtm, but without the trailing text :)
/lgtm

/assign @deads2k
for approval

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2018
@lavalamp
Copy link
Member

lavalamp commented Oct 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, logicalhan, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit f81b72f into kubernetes:master Oct 8, 2018
@logicalhan logicalhan mentioned this pull request Dec 8, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@deads2k deads2k

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@logicalhan @cheftako @nikhita @lavalamp @k8s-ci-robot @deads2k