Add fall-back to get node IP on host_path tests #68915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
k8s-ci-robot
added
sig/testing
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
After applying this PR, the test can pass on my local environment which doesn't support external IPs. |
As the same as the commit[1], this adds fall-back way to get a node IP address on host_path e2e tests for environments which don't support external IPs. [1]: kubernetes@4e7c2f6#diff-5ee86aefbb33223865bc542107ea8560L81
oomichi
force-pushed
the
issue/68914
branch
from
e10adb2
to
dd9cffb
Compare
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/assign @MrHohn |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@oomichi can you remove the dummy release note? Thanks. |
k8s-ci-robot
added
release-note-none
|
@MrHohn Oh, I missed that and removed. Thanks for your approval anyways :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As the same as the commit1, this adds fall-back way to get a
node IP address on host_path e2e tests for environments which
don't support external IPs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #68914
Release note:
None