Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Quobyte Tenant to QuobyteVolumeSource to enable deletion of persistent volumes #68925

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Adding Quobyte Tenant to QuobyteVolumeSource to enable deletion of persistent volumes #68925

merged 1 commit into from
Feb 5, 2019

Conversation

casusbelli
Copy link
Contributor

Adds the Quobyte tenant id to the QuobyteVolumeSource type and
updates the quobyte api client to support looking up
volume ids.

What this PR does / why we need it:
Fixes an issue where deleting dynamically provisioned persistent volumes failed to remove the Quobyte volume in the backend during pv deletion.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #65312

Special notes for your reviewer:

Release note:

Fixes a bug that prevented deletion of dynamically provisioned volumes in Quobyte backends.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @casusbelli. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 21, 2018
@casusbelli casusbelli mentioned this pull request Sep 21, 2018
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2018
@casusbelli
Copy link
Contributor Author

/assign @johscheuer
/assign @saad-ali
/assign @thockin

@k8s-ci-robot
Copy link
Contributor

@casusbelli: GitHub didn't allow me to assign the following users: johscheuer.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @johscheuer
/assign @saad-ali
/assign @thockin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@casusbelli
Copy link
Contributor Author

/review @johscheuer

@johscheuer
Copy link
Contributor

LGTM

@casusbelli
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@casusbelli: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2019
@thockin
Copy link
Member

thockin commented Jan 4, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2019
@msau42
Copy link
Member

msau42 commented Jan 4, 2019

how do we feel about small changes to built-in volumes at this point? This is well-contained and seems harmless.

It seems like this is necessary to fix a bug, so it seems ok to me. For new features, I would push towards CSI.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: casusbelli, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@casusbelli
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2019
@casusbelli
Adding Tenant to QuobyteVolumeSource
cc71b0a 
Adds the tenant id to the QuobyteVolumeSource type and
updates the quobyte api client to support looking up
volume ids.
@casusbelli
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@thockin
Copy link
Member

thockin commented Jan 26, 2019

/lgtm
/approve

@casusbelli
Copy link
Contributor Author

/test tide

(no idea if this check can be triggered like this but trying anyways)

@casusbelli
Copy link
Contributor Author

Mmh, shouldn't the /lgtm command be reflected in a corresponding label for this PR? Does this pr require further steps, e.g. because of itincluding a (minor) API change?
I couldn't find the answer in the docs so far.

@casusbelli casusbelli mentioned this pull request Feb 5, 2019
Closed
@nikhita
Copy link
Member

nikhita commented Feb 5, 2019

Looks like a dropped webhook, re-adding lgtm based on @thockin's lgtm above:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2019
@nikhita
Copy link
Member

nikhita commented Feb 5, 2019 via email

@k8s-ci-robot k8s-ci-robot merged commit f3a6dbc into kubernetes:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@jbeda jbeda Awaiting requested review from jbeda

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@thockin thockin

@saad-ali saad-ali

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing parameter in Quobyte volume plugin
8 participants
@casusbelli @k8s-ci-robot @johscheuer @thockin @msau42 @nikhita @jsafrane @saad-ali