Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import restrictions for csi-api #68942

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Add import restrictions for csi-api #68942

merged 2 commits into from
Nov 30, 2018

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Sep 21, 2018

The list of restrictions is as per csi-api's godeps.json: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/csi-api/Godeps/Godeps.json

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 21, 2018
@nikhita
Copy link
Member Author

nikhita commented Sep 21, 2018

/sig storage
/kind bug

/cc @sttts @saad-ali @jsafrane @verult

Related: kubernetes/publishing-bot#113

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 21, 2018
@nikhita nikhita mentioned this pull request Sep 21, 2018
Merged
@nikhita nikhita force-pushed the csi-api-staging-restrict-imports branch from 9114789 to c9d7001 Compare September 21, 2018 17:39
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2018
@nikhita
Copy link
Member Author

nikhita commented Sep 21, 2018

/retest

1 similar comment
@jsafrane
Copy link
Member

/retest

@sttts
Copy link
Contributor

sttts commented Oct 4, 2018

/lgtm
/approve
/hold

@saad-ali feel free to unhold when you think the dependencies are correct.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 4, 2018
@nikhita
Copy link
Member Author

nikhita commented Oct 4, 2018

Oh this needs a rebase. Will update.

@nikhita nikhita force-pushed the csi-api-staging-restrict-imports branch from c9d7001 to 202b683 Compare October 4, 2018 11:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2018
@nikhita
Copy link
Member Author

nikhita commented Oct 4, 2018 via email

@nikhita
Copy link
Member Author

nikhita commented Oct 23, 2018

@jsafrane @saad-ali Ptal.

@nikhita
Copy link
Member Author

nikhita commented Oct 23, 2018

Removing the hold since lgtm is gone anyway.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2018
@cblecker
Copy link
Member

needs rebase

@nikhita nikhita force-pushed the csi-api-staging-restrict-imports branch from 202b683 to a9c5994 Compare October 25, 2018 02:38
@nikhita
Copy link
Member Author

nikhita commented Oct 25, 2018

@cblecker Thanks. Rebased.

@cblecker
Copy link
Member

/assign @saad-ali

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2018
@nikhita nikhita force-pushed the csi-api-staging-restrict-imports branch from a9c5994 to b3ad9e6 Compare November 26, 2018 19:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2018
@nikhita
Copy link
Member Author

nikhita commented Nov 26, 2018

Rebased again. @jsafrane or @saad-ali can you take a look? Thanks!

@nikhita
Copy link
Member Author

nikhita commented Nov 26, 2018

/assign @jsafrane

@mikedanese mikedanese removed their request for review November 26, 2018 19:40
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@jsafrane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, nikhita, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1555655 into kubernetes:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

@sttts sttts Awaiting requested review from sttts

@verult verult Awaiting requested review from verult

Assignees

@sttts sttts

@jsafrane jsafrane

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nikhita @jsafrane @sttts @cblecker @k8s-ci-robot @fejta-bot @saad-ali