Fixes #65869 Do not listen insecurely if secure port is specified

[aruneli]

What this PR does / why we need it:
Make ccm not listen insecurely if secure port is specified

Which issue(s) this PR fixes:
#65869

Special notes for your reviewer:

I have made it such that the insecure port will be turned off if the secure-port flag is used. Here is the new behavior with this PR.

1. By default, ccm only listens on secure port 10258
2. If secure port is set, only secure port is changed to new port
3. If only --port option is used, the ccm will listen on insecure port and default secure port (current behavior)
4. If both --port and --secure-port are provided, then current behavior is retained

CCM server will not listen insecurely if secure port is specified

@stts @andrewsykim @jhorwit2 @wlan0 Please review

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aruneli]

/assign @wlan0

[wlan0]

Thanks for the PR @aruneli

LGTM. Pulled the code and tested it.

@stts @andrewsykim @jhorwit2 Pls review as well.

[wlan0]

/ok-to-test

[wlan0]

@aruneli There is a test failure. Pls fix

[neolit123]

/check cla
/kind bug

[aruneli]

I signed it

[aruneli]

/retest

[aruneli]

/retest

[aruneli]

/retest

[stewart-yu]

I'm little confused about this PR, seems discard the 10253 port absolutly?

[stewart-yu]

Have you signed the CLA?

[aruneli]

/check-cla

[fedebongio]

/assign @cheftako

[cheftako]

It looks like it will change the behavior of the CCM CLI. Before your change it would default to listening on port 10253 unless you explicitly turned off the port. With your change the server will not listen to that port (more secure) however that is a change. If the change was after the deprecation period, then the option would just be done away with. Before the deprecation period, I think it at least needs an action release note. I believe the deprecation was recent so we should make sure to have an action release note.

[aruneli]

/release-note

[k8s-ci-robot]

@aruneli: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cheftako]

/lgtm

[wlan0]

/approve

[wlan0]

Ping @foxish

[foxish]

/approve for the test change

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruneli, cheftako, foxish, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/cloud-controller-manager/OWNERS [wlan0]
• test/OWNERS [foxish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aruneli]

/test pull-kubernetes-typecheck

[aruneli]

/test pull-kubernetes-verify