Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default backend image #69120

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Update default backend image #69120

merged 1 commit into from
Oct 3, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 26, 2018

What this PR does / why we need it:

Update docker image for default backend service (render 404 page)

Release note:

Update defaultbackend image to 1.5. Users should concentrate on updating scripts to the new version.

@bowei @timstclair

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2018
@bowei
Copy link
Member

bowei commented Sep 27, 2018

/retest

@bowei
Copy link
Member

bowei commented Sep 27, 2018

/assign
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2018
@bowei
Copy link
Member

bowei commented Sep 27, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2018
@bowei
Copy link
Member

bowei commented Sep 27, 2018

/hold remove

@bowei
Copy link
Member

bowei commented Sep 27, 2018

/hold

I can't find that container image for some reason: k8s.gcr.io/defaultbackend:1.5

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2018

@bowei you need to publish the image first kubernetes/ingress-nginx#3125 (comment) 😄

@bowei
Copy link
Member

bowei commented Sep 29, 2018

i pushed k8s.gcr.io/defaultbackend-amd64:1.5

can you update accordingly

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2018
@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2018

/test pull-kubernetes-e2e-gce

@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2018

/test pull-kubernetes-e2e-gke

@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2018

/test pull-kubernetes-integration

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2018

/test pull-kubernetes-integration

@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2018

/test pull-kubernetes-e2e-gce

@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2018

@bowei ping

@bowei
Copy link
Member

bowei commented Oct 1, 2018

one sec -- i need to upload the other architectures.

@bowei
Copy link
Member

bowei commented Oct 2, 2018

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 2, 2018
@bowei
Copy link
Member

bowei commented Oct 2, 2018

can someone who owns the juju/ code review this?

@castrojo
@chuckbutler
@marcoceppi
@mbruzek
@Cynerva
@ktsakalozos

@Cynerva
Copy link
Contributor

Cynerva commented Oct 2, 2018

/approve

Thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei, Cynerva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@nikhita
Copy link
Member

nikhita commented Oct 3, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit c520b2c into kubernetes:master Oct 3, 2018
@numbsafari
Copy link

Sorry if this is the wrong place to ask this question, but... what is the provenance of the defaultbackend image? Is there a github repo that it originates from?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aledbf @bowei @Cynerva @k8s-ci-robot @nikhita @numbsafari