Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct kubelet service file permission #69127

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

daixiang0
Copy link
Contributor

To fix below waring:
systemd[1]: Configuration file /etc/systemd/system/kubelet.service is marked executable. Please remove executable permission bits. Proceeding anyway.

Signed-off-by: Xiang Dai 764524258@qq.com

To fix below waring:
systemd[1]: Configuration file /etc/systemd/system/kubelet.service is marked executable. Please remove executable permission bits. Proceeding anyway.

Signed-off-by: Xiang Dai <764524258@qq.com>
@k8s-ci-robot
Copy link
Contributor

@daixiang0: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2018
@nikhita
Copy link
Member

nikhita commented Oct 3, 2018

/sig release
/kind bug

/assign @mikedanese @dims
because you reviewed #66669

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2018
@nikhita
Copy link
Member

nikhita commented Oct 3, 2018

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2018
@daixiang0
Copy link
Contributor Author

ping @nikhita test is ok now

@nikhita
Copy link
Member

nikhita commented Oct 9, 2018

@dims @mikedanese ptal, this is similar to #66669

@dims
Copy link
Member

dims commented Oct 9, 2018

@randomvariable can you please take a look?

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@randomvariable
Copy link
Member

randomvariable commented Oct 15, 2018

@daixiang0 , I don't have the rights I think, though I can try...

/approve

@daixiang0
Copy link
Contributor Author

@dims @mikedanese any update?

@dims
Copy link
Member

dims commented Oct 15, 2018

/assign @timothysc

/lgtm

@dims
Copy link
Member

dims commented Oct 15, 2018

/assign @mikedanese

@mikedanese
Copy link
Member

/lgtm

@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daixiang0, mikedanese, randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@nikhita
Copy link
Member

nikhita commented Oct 16, 2018 via email

@nikhita
Copy link
Member

nikhita commented Oct 16, 2018 via email

@k8s-ci-robot k8s-ci-robot merged commit 96670e4 into kubernetes:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants