Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI sidecar containers 0.4.0 #69154

Merged
merged 1 commit into from
Oct 2, 2018
Merged

CSI sidecar containers 0.4.0 #69154

merged 1 commit into from
Oct 2, 2018

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Sep 27, 2018

What this PR does / why we need it:

This updates the versions of the sidecar containers so that the latest stable releases are used, the ones that get released together with Kubernetes 1.12.

Special notes for your reviewer:

This includes the rebased commit from PR #68887, which is needed because the new external-attacher requires additional permissions for leader election.

Release note:

NONE

/sig storage

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2018
@pohly
Copy link
Contributor Author

pohly commented Sep 27, 2018

@saad-ali, @jsafrane shall we focus on merging this PR instead of PR #68887? The latter one would need rebasing, something that I have done here already.

@dims
Copy link
Member

dims commented Sep 27, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2018
@pohly
Copy link
Contributor Author

pohly commented Sep 28, 2018

/retest

@jsafrane
Copy link
Member

jsafrane commented Oct 1, 2018

I rebased my PR and I got all approvals, so it might be easier to merge #68887 first. I can approve this one then.

@pohly
Copy link
Contributor Author

pohly commented Oct 1, 2018 via email

@pohly
E2E CSI: bump versions of sidecar containers to 0.4.0
39d28d1 
The 0.4.0 versions are what is getting released together with and for
Kubernetes 1.12.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2018
@pohly
Copy link
Contributor Author

pohly commented Oct 1, 2018

/assign jsafrane

@jsafrane I rebased on top of your merged PR, please approve this one.

@jsafrane
Copy link
Member

jsafrane commented Oct 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2018
@pohly
Copy link
Contributor Author

pohly commented Oct 1, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 1, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a9823bc into kubernetes:master Oct 2, 2018
@verult verult mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@jeffvance jeffvance Awaiting requested review from jeffvance

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pohly @dims @jsafrane @k8s-ci-robot @fejta-bot