-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mountoptions support for local storage #69211
Conversation
@lichuqiang: GitHub didn't allow me to request PR reviews from the following users: wenlxie. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think in SetUp we also need to process the mount options |
add commit to process the mount options in SetUp |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lichuqiang, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
partially address #68317.
As we've already distinguished volume source type, and tried to fetch mountOptions for that of block here in local plugin, we don't need extra in-tree change but just enable
SupportsMountOption()
.Will post a follw-up PR in the external plugin to pass mount options into pv spec.
Release note:
/sig storage
/kind feature
/assign @msau42
/cc @wenlxie