Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mountoptions support for local storage #69211

Merged
merged 2 commits into from
Oct 3, 2018
Merged

mountoptions support for local storage #69211

merged 2 commits into from
Oct 3, 2018

Conversation

lichuqiang
Copy link
Contributor

What this PR does / why we need it:
partially address #68317.

As we've already distinguished volume source type, and tried to fetch mountOptions for that of block here in local plugin, we don't need extra in-tree change but just enable SupportsMountOption().

Will post a follw-up PR in the external plugin to pass mount options into pv spec.

Release note:

NONE

/sig storage
/kind feature
/assign @msau42
/cc @wenlxie

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 28, 2018
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2018
@k8s-ci-robot
Copy link
Contributor

@lichuqiang: GitHub didn't allow me to request PR reviews from the following users: wenlxie.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
partially address #68317.

As we've already distinguished volume source type, and tried to fetch mountOptions for that of block here in local plugin, we don't need extra in-tree change but just enable SupportsMountOption().

Will post a follw-up PR in the external plugin to pass mount options into pv spec.

Release note:

NONE

/sig storage
/kind feature
/assign @msau42
/cc @wenlxie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42
Copy link
Member

msau42 commented Sep 28, 2018

I think in SetUp we also need to process the mount options

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2018
@lichuqiang
Copy link
Contributor Author

add commit to process the mount options in SetUp

@msau42
Copy link
Member

msau42 commented Oct 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichuqiang, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 02df80d into kubernetes:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants