Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl drain/cmd test: remove testapi dependency #69342

Merged
merged 1 commit into from
Oct 3, 2018
Merged

kubectl drain/cmd test: remove testapi dependency #69342

merged 1 commit into from
Oct 3, 2018

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Oct 2, 2018

  • Remove testapi dependency from drain_test and cmd_test.
  • Remove unneeded self_link in test data.
  • Consistently use the kubectl scheme codec.

Helps Address:
kubernetes/kubectl#83

NONE

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 2, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 2, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 2, 2018

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 2, 2018

/assign

@seans3
Copy link
Contributor Author

seans3 commented Oct 2, 2018

/cc @apelisse
/cc @juanvallejo

apelisse
apelisse reviewed Oct 2, 2018
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitive improvement.

/lgtm

pkg/kubectl/cmd/cmd_test.go
pods := &corev1.PodList{
ListMeta: metav1.ListMeta{
ResourceVersion: "15",
},
Items: []corev1.Pod{
{
ObjectMeta: metav1.ObjectMeta{Name: "foo", Namespace: "test", ResourceVersion: "10"},
Spec: apitesting.V1DeepEqualSafePodSpec(),
Spec: corev1.PodSpec{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 2, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 2, 2018

/retest

@apelisse
Copy link
Member

apelisse commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab8a061 into kubernetes:master Oct 3, 2018
@seans3 seans3 deleted the drain-cmd-test-fix branch October 3, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse apelisse left review comments

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@apelisse apelisse

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @apelisse @k8s-ci-robot