Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP: Remove the deprecated google-json-key support #69354

Merged
merged 1 commit into from
Oct 13, 2018
Merged

GCP: Remove the deprecated google-json-key support #69354

merged 1 commit into from
Oct 13, 2018

Conversation

yujuhong
Copy link
Contributor

@yujuhong yujuhong commented Oct 2, 2018

The flag was deprecated in 1.10. According to the deprecation policy, it
is safe to remove the flag now.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Remove the deprecated --google-json-key flag from kubelet.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2018
@yujuhong
GCP: Remove the deprecated google-json-key support
ed92397 
The flag was deprecated in 1.10. According to the deprecation policy, it
is safe to remove the flag now.
@k8s-ci-robot k8s-ci-robot added area/kubeadm area/kubelet sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2018
@neolit123
Copy link
Member

/sig gcp
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/gcp kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 3, 2018
@yujuhong
Copy link
Contributor Author

yujuhong commented Oct 3, 2018

/retest

2 similar comments
@yujuhong
Copy link
Contributor Author

yujuhong commented Oct 3, 2018

/retest

@yujuhong
Copy link
Contributor Author

/retest

@yujuhong
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Oct 12, 2018

/approve
/assign @mtaufen

@yujuhong
Copy link
Contributor Author

/assign @mikedanese
for approval

@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@mtaufen
Copy link
Contributor

mtaufen commented Oct 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2018
@yujuhong
Copy link
Contributor Author

/retest

@yujuhong
Copy link
Contributor Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit e4200ce into kubernetes:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis Awaiting requested review from eparis

@thockin thockin Awaiting requested review from thockin

Assignees

@mtaufen mtaufen

@liggitt liggitt

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yujuhong @neolit123 @liggitt @mikedanese @k8s-ci-robot @mtaufen