Add validation for percentage-of-nodes-to-score of the scheduler config #69355
Conversation
k8s-ci-robot
added
sig/scheduling
k8s-ci-robot
added
the
approved
|
/kind bug |
k8s-ci-robot
added
kind/bug
bsalamat
requested review from
ravisantoshgudimetla
and removed request for
caesarxuchao and
thockin
| @@ -58,7 +58,8 @@ func TestValidateKubeSchedulerConfiguration(t *testing.T) { | |||
| RetryPeriod: metav1.Duration{Duration: 5 * time.Second}, | |||
| }, | |||
| }, | |||
| BindTimeoutSeconds: &testTimeout, | |||
| BindTimeoutSeconds: &testTimeout, | |||
| PercentageOfNodesToScore: 35, | |||
There was a problem hiding this comment.
Curious about 35. Was it chosen randomly :P ?
There was a problem hiding this comment.
Yes. Just a valid number (between 0 and 100) to test our validation.
| @@ -136,6 +140,10 @@ func TestValidateKubeSchedulerConfiguration(t *testing.T) { | |||
| expectedToFail: true, | |||
| config: bindTimeoutUnset, | |||
| }, | |||
| "bad-percentage-of-nodes-to-score": { | |||
| expectedToFail: true, | |||
| config: percentageOfNodesToScore101, | |||
There was a problem hiding this comment.
Probably a positive test case as well?
There was a problem hiding this comment.
The positive test case exists. It is labeled as "good" in the switch statement. The number 35 that I have added above is for the valid case.
There was a problem hiding this comment.
Ohh sorry github UI wasn't showing as it wasn't a new change, so did not notice. Thanks.
There was a problem hiding this comment.
Thanks @bsalamat. Do you want to cherrypick this to 1.12, if the config validation is available in that release?
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The config validation for the scheduler was added almost at the same time we added "percentage-of-nodes-to-score". So, it was missing in the validation logic. This PR adds the validation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
/sig scheduling