Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick: Update defaultbackend to v1.5 #69381

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Cherrypick: Update defaultbackend to v1.5 #69381

merged 1 commit into from
Dec 16, 2018

Conversation

bowei
Copy link
Member

@bowei bowei commented Oct 3, 2018 

Updates defaultbackend to 1.5

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@bowei bowei changed the title Update defaultbackend to v1.5 Cherrypick: Update defaultbackend to v1.5 Oct 3, 2018
@MaciekPytel
Copy link
Contributor

@bowei Can you add a link to release notes of the new version, or some other indication of what are the changes?

@MaciekPytel
Copy link
Contributor

@bowei Do we need this in 1.10.10? If so it needs to be lgtm-ed today.

@MaciekPytel
Copy link
Contributor

/hold
For 1.10.10

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2018
@jonpulsifer
Copy link
Contributor

@MaciekPytel Ref kubernetes/ingress-nginx#3125 this is the PR that resulted in defaultbackend-amd:1.5

tl;dr: placed /metrics and /healthz behind tcp:10254

in > 1.5 there will be no /metrics endpoint

(ps you can find defaultbackend here now)

@MaciekPytel
Copy link
Contributor

/hold cancel

@bowei @jonpulsifer This still needs lgtm. It also needs to merge by Thursday to make it into 1.10.12, which will be the last patch release for 1.10.

Finally, I'd appreciate if you edit the release note to contain the information on what changed in 1.5 (one sentence summary of @jonpulsifer comment above).

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 10, 2018
@bowei
Copy link
Member Author

bowei commented Dec 14, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@bowei: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaciekPytel
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2018
@MaciekPytel MaciekPytel removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 16, 2018
@MaciekPytel
Copy link
Contributor

/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit c757b93 into kubernetes:release-1.10 Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@nicksardo nicksardo Awaiting requested review from nicksardo

Assignees

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bowei @k8s-ci-robot @MaciekPytel @jonpulsifer