Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: fix printf format error #69392

Merged
merged 1 commit into from
Oct 4, 2018
Merged

kubeadm: fix printf format error #69392

merged 1 commit into from
Oct 4, 2018

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Oct 3, 2018 •
edited

go test in 1.11 verifies format strings; this fix is needed for the test to
pass with go 1.11.

NONE

@justinsb
kubeadm: fix printf format error
34b8433 
go test in 1.11 verifies format strings; this fix is needed for the
test to pass with go 1.11.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2018
@justinsb
Copy link
Member Author

justinsb commented Oct 3, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 3, 2018
@justinsb justinsb requested a review from liztio October 3, 2018 19:30
@justinsb
Copy link
Member Author

justinsb commented Oct 3, 2018

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 3, 2018
BenTheElder
BenTheElder approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@cblecker
Copy link
Member

cblecker commented Oct 3, 2018

/lgtm

@cblecker cblecker mentioned this pull request Oct 3, 2018
Closed
@cblecker
Copy link
Member

cblecker commented Oct 3, 2018

/assign @timothysc
for approval

timothysc
timothysc approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, justinsb, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@cblecker
Copy link
Member

cblecker commented Oct 3, 2018

/test all

@cblecker
Copy link
Member

cblecker commented Oct 4, 2018

/test pull-kubernetes-integration

@justinsb
Copy link
Member Author

justinsb commented Oct 4, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 50ce55e into kubernetes:master Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 34b8433 link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@BenTheElder BenTheElder BenTheElder approved these changes

@liztio liztio Awaiting requested review from liztio

Assignees

@timothysc timothysc

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justinsb @cblecker @k8s-ci-robot @timothysc @BenTheElder