Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl fake test factory: replace legacyscheme with kubectl scheme #69404

Merged
merged 1 commit into from
Oct 4, 2018
Merged

kubectl fake test factory: replace legacyscheme with kubectl scheme #69404

merged 1 commit into from
Oct 4, 2018

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Oct 3, 2018

  • Replaces dependency on legacyscheme (which registers internal types) with kubectl scheme.

Helps address:
kubernetes/kubectl#83

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/kubectl needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 3, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 3, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 3, 2018

/assign

@seans3
Copy link
Contributor Author

seans3 commented Oct 4, 2018

/retest

@seans3
Copy link
Contributor Author

seans3 commented Oct 4, 2018

/cc @juanvallejo
/cc @apelisse

@apelisse
Copy link
Member

apelisse commented Oct 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 34e2688 into kubernetes:master Oct 4, 2018
@seans3 seans3 deleted the fake-test-fix branch October 4, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@dixudx dixudx Awaiting requested review from dixudx

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@apelisse apelisse

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @apelisse @k8s-ci-robot @juanvallejo