Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort bind options in JoinMountOptions #69451

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Sort bind options in JoinMountOptions #69451

merged 1 commit into from
Oct 7, 2018

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Oct 5, 2018

We were not sorting them previously, which made the order
non-deterministic. If we believe the order doesn't matter, let's pick a
consistent order to minimize the chances of a rare flake.

This also simplifies the unit tests, which were flaking not-very-rarely,
e.g. with

bazel test //pkg/volume/awsebs/... --runs_per_test=8

@justinsb
Sort bind options in JoinMountOptions
3c4789b 
We were not sorting them previously, which made the order
non-deterministic.  If we believe the order doesn't matter, let's pick
a consistent order to minimize the chances of a rare flake.

This also simplifies the unit tests, which were flaking
not-very-rarely, e.g. with

`bazel test //pkg/volume/awsebs/... --runs_per_test=8`
@k8s-ci-robot
Copy link
Contributor

@justinsb: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 5, 2018
@justinsb
Copy link
Member Author

justinsb commented Oct 5, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 5, 2018
@justinsb
Copy link
Member Author

justinsb commented Oct 5, 2018

AFAICT this was introduced in 2d3008f and never touched, and there was no particular reason not to sort the options. @gnufied ?

@justinsb justinsb requested a review from gnufied October 5, 2018 01:46
@justinsb
Copy link
Member Author

justinsb commented Oct 5, 2018

bazel test //pkg/volume/gcepd/... --runs_per_test=10 also usually fails on master

@gnufied
Copy link
Member

gnufied commented Oct 5, 2018

@justinsb yeah the ordering of mount options only matter when they conflict with each other, then last one wins. I think we should be fine.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2018
@justinsb
Copy link
Member Author

justinsb commented Oct 5, 2018

/retest

Tests are taking longer and longer to complete, not entirely sure why yet. And so these tests are starting to timeout more often..

@neolit123
Copy link
Member

/sig aws
/kind design

@k8s-ci-robot k8s-ci-robot added sig/aws kind/design Categorizes issue or PR as related to design. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit a29b093 into kubernetes:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@rootfs rootfs Awaiting requested review from rootfs

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @k8s-ci-robot @gnufied @neolit123