Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link in CHANGELOG-1.12.md #69501

Closed
wants to merge 1 commit into from
Closed

fix link in CHANGELOG-1.12.md #69501

wants to merge 1 commit into from

Conversation

Pingan2017
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2018
@Pingan2017
Copy link
Member Author

/kind cleanup
/sig release
/assign @monopole

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 8, 2018
@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 8, 2018
@wgliang
Copy link
Contributor

wgliang commented Oct 8, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 8, 2018
@krmayankk
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@Pingan2017
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@Pingan2017
Copy link
Member Author

ping @monopole Could you take a look and approve this? Thank u!

@Pingan2017
Copy link
Member Author

ping @lavalamp @thockin Can you take a look? Thanks

nikhita
nikhita reviewed Dec 11, 2018
View reviewed changes
CHANGELOG-1.12.md Outdated
@@ -147,7 +147,7 @@ filename | sha512 hash

## Known Issues

- Feature [#566](https://github.com/kubernetes/kubernetes/issues/566) enabling CoreDNS as the default for kube-up deployments was dropped from the release due to a scalability memory resource consumption issue observed. If a cluster operator is considering using CoreDNS on a cluster greater than 2000 nodes, it may be necessary to give more consideration to CoreDNS pod memory resource limits and experimentally measure that memory usage versus cluster resource availability.
- Feature [#566](https://github.com/kubernetes/features/issues/566) enabling CoreDNS as the default for kube-up deployments was dropped from the release due to a scalability memory resource consumption issue observed. If a cluster operator is considering using CoreDNS on a cluster greater than 2000 nodes, it may be necessary to give more consideration to CoreDNS pod memory resource limits and experimentally measure that memory usage versus cluster resource availability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/enhancements/features

The features repo was renamed as enhancements recently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

@nikhita
Copy link
Member

nikhita commented Dec 11, 2018

@Pingan2017 Sorry for the delay here! Can you make changes as per the comment? Will try to get it approved after that.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@nikhita
Copy link
Member

nikhita commented Dec 12, 2018

/lgtm

/assign @liggitt
for approval

@k8s-ci-robot k8s-ci-robot assigned liggitt and nikhita and unassigned liggitt Dec 12, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@liggitt
Copy link
Member

liggitt commented Dec 12, 2018

is that change needed anywhere else in the repo? if so, let's find/replace all at once

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/kubeadm kind/documentation Categorizes issue or PR as related to documentation. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pingan2017
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liggitt

If they are not already assigned, you can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Pingan2017
Copy link
Member Author

/close
I will file a new pr 😄

@k8s-ci-robot
Copy link
Contributor

@Pingan2017: Closed this PR.

In response to this:

/close
I will file a new pr 😄

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Pingan2017 Pingan2017 deleted the link-in-changelog branch December 12, 2018 03:29
@k8s-ci-robot
Copy link
Contributor

@Pingan2017: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e 0776668 link /test pull-kubernetes-node-e2e
pull-kubernetes-bazel-build 0776668 link /test pull-kubernetes-bazel-build
pull-kubernetes-bazel-test 0776668 link /test pull-kubernetes-bazel-test
pull-kubernetes-integration 0776668 link /test pull-kubernetes-integration
pull-kubernetes-cross 0776668 link /test pull-kubernetes-cross
pull-kubernetes-verify 0776668 link /test pull-kubernetes-verify
pull-kubernetes-e2e-gce 0776668 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-100-performance 0776668 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 0776668 link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-gke 0776668 link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Pingan2017
Copy link
Member Author

new pr #71979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@monopole monopole

@nikhita nikhita

@krmayankk krmayankk

Labels
area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Pingan2017 @wgliang @krmayankk @nikhita @liggitt @k8s-ci-robot @monopole