Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find-binary to locate bazel e2e tests #69548

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

tallclair
Copy link
Member

@tallclair tallclair commented Oct 9, 2018

What this PR does / why we need it:

bazel build test/e2e/e2e.test places the output in bazel-bin/test/e2e/e2e.test, NOT in bazel-bin/test/e2e/linux_amd64_stripped/e2e.test as it does with other binaries. This change extends kube::util::find-binary-for-platform() to include the not platform-subpath in the search.

Special notes for your reviewer:

Insert: "I have no idea what I'm doing" meme.

Could this break anything?

Release note:

NONE

/sig testing

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 9, 2018
@ixdy
Copy link
Member

ixdy commented Oct 9, 2018

/cc @BenTheElder

@BenTheElder
Copy link
Member

Not exactly related to this PR, but it seems we check the non-platform specific locations first, i'm not sure how correct / useful this method is meant to be beyond "find something that maybe has that name" ...

https://github.com/kubernetes/kubernetes/pull/69548/files#diff-ef2873ebed657da627ed30f61dea2964R160

if that's the case, this seems fine to me

@tallclair tallclair added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 9, 2018
@ixdy
Copy link
Member

ixdy commented Oct 11, 2018

@BenTheElder the ls -t line returns whichever location is most-recently updated.

@ixdy
Copy link
Member

ixdy commented Oct 11, 2018

/lgtm
/hold

Do both hack/ginkgo-e2e.sh and cluster/kubectl.sh find the respective bazel-built binaries (e2e.test and kubectl) with this change?

I'd test it myself, but I'm on plane wifi at the moment.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 11, 2018
@ixdy
Copy link
Member

ixdy commented Oct 11, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2018
@fejta
Copy link
Contributor

fejta commented Oct 11, 2018

Please pass tests

@ixdy
Copy link
Member

ixdy commented Oct 11, 2018

those look like flakes?
/retest

@ixdy
Copy link
Member

ixdy commented Oct 11, 2018

also it appears to do the right thing.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-ci-robot added a commit that referenced this pull request Feb 26, 2019
…548-origin-release-1.12

Automated cherry pick of #69548: Fix find-binary to locate bazel e2e tests
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2019
…548-origin-release-1.11

Automated cherry pick of #69548: Fix find-binary to locate bazel e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants