-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix find-binary to locate bazel e2e tests #69548
Conversation
/cc @BenTheElder |
Not exactly related to this PR, but it seems we check the non-platform specific locations first, i'm not sure how correct / useful this method is meant to be beyond "find something that maybe has that name" ... https://github.com/kubernetes/kubernetes/pull/69548/files#diff-ef2873ebed657da627ed30f61dea2964R160 if that's the case, this seems fine to me |
@BenTheElder the |
/lgtm Do both I'd test it myself, but I'm on plane wifi at the moment. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please pass tests |
those look like flakes? |
also it appears to do the right thing. |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
…548-origin-release-1.12 Automated cherry pick of #69548: Fix find-binary to locate bazel e2e tests
…548-origin-release-1.11 Automated cherry pick of #69548: Fix find-binary to locate bazel e2e tests
What this PR does / why we need it:
bazel build test/e2e/e2e.test
places the output inbazel-bin/test/e2e/e2e.test
, NOT inbazel-bin/test/e2e/linux_amd64_stripped/e2e.test
as it does with other binaries. This change extendskube::util::find-binary-for-platform()
to include the not platform-subpath in the search.Special notes for your reviewer:
Insert: "I have no idea what I'm doing" meme.
Could this break anything?
Release note:
/sig testing