Fix WaitTimeoutForPodEvent logic #69549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
tallclair
force-pushed
the
podevent-test
branch
from
5c96673
to
5461880
Compare
|
/retest |
k8s-ci-robot
added
kind/cleanup
|
/approve |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/assign @saad-ali |
tallclair
force-pushed
the
podevent-test
branch
from
5461880
to
14bd9f5
Compare
k8s-ci-robot
added
size/S
|
Ran into a flake where no events had been recorded yet, so updated the method to keep waiting when no events are found. @mrunalp PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
tallclair
force-pushed
the
podevent-test
branch
from
14bd9f5
to
5214be3
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
Fixed spelling. |
|
Reapplying lgtm for trivial fix. |
tallclair
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, saad-ali, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The framework method
WaitTimeoutForPodEventwas returning an error when an event was found with the correct error message. The only test calling this method compensated by expecting the event to occur, but didn't distinguish what triggered the error.This PR inverts the logic of the helper method (look for an event with the matching string), and flips the corresponding test logic.
Release note:
/area test
/assign @mrunalp