-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubadm: remove misleading message in init
#69586
kubadm: remove misleading message in init
#69586
Conversation
The message right before the kubelet boots up the control plane is misleading because the image pulling is now part of preflight. Remove the message.
/retest |
1 similar comment
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
What this PR does / why we need it:
The message right before the kubelet boots up the control
plane is misleading because the image pulling is now part of
preflight.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):NONE
Special notes for your reviewer:
NONE
Release note:
/assign @fabriziopandini
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/kind cleanup