Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pod status.phase check from pod event handlers #69592

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Remove pod status.phase check from pod event handlers #69592

merged 1 commit into from
Oct 10, 2018

Conversation

bsalamat
Copy link
Member

@bsalamat bsalamat commented Oct 9, 2018

What this PR does / why we need it:
The scheduler pod informer already filters out pods which are terminated (succeeded or failed). As a result, we do not need to check pods' phase again in the scheduler event handlers.

Release note:

NONE

/sig scheduling

@bsalamat bsalamat added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2018
yastij
yastij approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@yastij
Copy link
Member

yastij commented Oct 9, 2018

/hold

Mostly LGTM but adding a hold, feel free to remove it once everyone is okay

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2018
misterikkit
misterikkit reviewed Oct 9, 2018
View reviewed changes
Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bsalamat
Copy link
Member Author

bsalamat commented Oct 9, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2018
@bsalamat
Copy link
Member Author

bsalamat commented Oct 9, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5442f9d into kubernetes:master Oct 10, 2018
@misterikkit misterikkit mentioned this pull request Oct 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterikkit misterikkit misterikkit left review comments

@yastij yastij yastij approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@resouer resouer Awaiting requested review from resouer

Assignees

@misterikkit misterikkit

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bsalamat @k8s-ci-robot @yastij @misterikkit