Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable and improve e2e of NoExecuteTaintManager #69657

Merged
merged 1 commit into from
Oct 16, 2018
Merged

enable and improve e2e of NoExecuteTaintManager #69657

merged 1 commit into from
Oct 16, 2018

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Oct 11, 2018 •
edited

  • e2e test file cannot end with "_test.go". rename "taints_test.go" to "taints.go"
  • test multiple pods case

What this PR does / why we need it:

This PR is to enable and improve e2e of NoExecuteTaintManager - which is in charge of evicting pods which don't have required tolerations.

Notice that no matter TaintBasedEvictions is enabled or not, this e2e test is supposed to be working correctly.

Which issue(s) this PR fixes:

Although it's a standalone PR, enabling it can gain more confidence to promote TaintBasedEvictions to beta.

Special notes for your reviewer:

Once this is merged, it's supposed to be running regularly in test grid, and displayed in https://k8s-testgrid.appspot.com/sig-scheduling#gce-serial.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2018
@Huang-Wei
Copy link
Member Author

/sig scheduling
/assign @k82cn

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2018
@Huang-Wei Huang-Wei mentioned this pull request Oct 11, 2018
Closed
7 tasks
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 11, 2018
@Huang-Wei
Copy link
Member Author

/retest

@Huang-Wei
Copy link
Member Author

cc/ @ravisantoshgudimetla @bsalamat

@Huang-Wei
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 11, 2018
bsalamat
bsalamat reviewed Oct 15, 2018
View reviewed changes
test/e2e/scheduling/taints.go Outdated
framework.Logf("Noticed Pod %q gets evicted.", podName)
evicted++
if evicted == 2 {
break FORLOOP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not changing for to for evicted != 2 and remove this if statement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Will update.

test/e2e/scheduling/taints.go Outdated
}
}
}
if evicted < 2 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the above loop this will never be true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

@Huang-Wei
enable and improve e2e of NoExecuteTaintManager
8726ed2 
- e2e test file cannot end with "_test.go". rename "taints_test.go" to "taints.go"
- test multiple pods case
bsalamat
bsalamat approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @Huang-Wei!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@k82cn
Copy link
Member

k82cn commented Oct 16, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 151830e into kubernetes:master Oct 16, 2018
@Huang-Wei Huang-Wei deleted the e2e-NoExecuteTaintManager branch October 16, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@davidopp davidopp Awaiting requested review from davidopp

@resouer resouer Awaiting requested review from resouer

Assignees

@bsalamat bsalamat

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Huang-Wei @k82cn @k8s-ci-robot @fejta-bot @bsalamat