Add tolerations for Stackdriver Logging and Metadata Agents. #69737
Conversation
k8s-ci-robot
added
release-note
|
/assign @MaciekPytel |
|
/assign @x13n |
|
/ok-to-test |
k8s-ci-robot
added
lgtm
| @@ -58,6 +58,11 @@ spec: | |||
| restartPolicy: Always | |||
| schedulerName: default-scheduler | |||
| terminationGracePeriodSeconds: 30 | |||
| tolerations: | |||
There was a problem hiding this comment.
Discussion topic: do we need similar tolerations in the cluster-level agent spec? I suspect the only reason we would is if all nodes are tainted. @x13n @MaciekPytel @kawych @piosz @bmoyles0117
There was a problem hiding this comment.
Some of that conversation happened in #68920 (comment).
There was a problem hiding this comment.
Ah, thanks for the pointer. I see the priority class now. Given that we'll only cherry-pick this into 1.12 and 1.11, this should work. If we ever need a 1.10 cherry-pick, we'd have to add stronger tolerations (e.g., CriticalAddonsOnly).
There was a problem hiding this comment.
CriticalAddonsOnly isn't really stronger - the ones added here are wildcard ones, so they include it already.
There was a problem hiding this comment.
I meant for the cluster-level agent, which currently doesn't have any tolerations.
There was a problem hiding this comment.
Oh, right. I think if someone is tainting all their nodes, something may break anyway, but yes, this could at least mitigate the problem in 1.10.
There was a problem hiding this comment.
I think a lot of things won't schedule if you taint all your nodes (DNS, metrics-server, ...). I don't think cluster-level agent should have stronger tolerations than other cluster-level system components.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qingling128, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
Created cherry-pick PRs into |
…69737-upstream-release-1.12 Automated cherry pick of #69737: Add tolerations for Stackdriver Logging and Metadata Agents.
…69737-upstream-release-1.11 Automated cherry pick of #69737: Add tolerations for Stackdriver Logging and Metadata Agents.
…69737-upstream-release-1.10 Automated cherry pick of #69737: Add tolerations for Stackdriver Logging and Metadata Agents.
What this PR does / why we need it:
Followup of #68920. This makes sure taints are respected.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: