-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue that e2e script exits due to unbound variables #69757
Conversation
/hold |
/kind bug |
/hold cancel @BenTheElder PTAL. |
not sure if this is actually correct, will leave to cluster/ reviewers |
This just allows the method to not fail if those env vars aren't set, which seems fine in the skeleton implementation. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In a kubeadm env, when running
go run hack/e2e.go -- --provider=skeleton --test --test_args="--ginkgo.focus=TaintBasedEvictions"
, it outputs:Special notes for your reviewer:
I'm using latest
master
branch in k/k.Release note:
/sig testing