Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue that e2e script exits due to unbound variables #69757

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Oct 13, 2018

What this PR does / why we need it:

In a kubeadm env, when running go run hack/e2e.go -- --provider=skeleton --test --test_args="--ginkgo.focus=TaintBasedEvictions", it outputs:

2018/10/12 19:18:42 e2e.go:79: Calling kubetest --verbose-commands=true --provider=skeleton --test --test_args=--ginkgo.focus=TaintBasedEvictions...
2018/10/12 19:18:42 process.go:153: Running: ./hack/e2e-internal/e2e-status.sh
Skeleton Provider: prepare-e2e not implemented
......
/root/go/src/k8s.io/kubernetes/cluster/../cluster/skeleton/util.sh: line 22: KUBE_MASTER_IP: unbound variable
2018/10/12 19:23:08 process.go:155: Step './hack/ginkgo-e2e.sh --ginkgo.focus=TaintBasedEvictions' finished in 30.036621ms
2018/10/12 19:23:08 main.go:311: Something went wrong: encountered 1 errors: [error during ./hack/ginkgo-e2e.sh --ginkgo.focus=TaintBasedEvictions: exit status 1]
2018/10/12 19:23:08 e2e.go:81: err: exit status 1
exit status 1

Special notes for your reviewer:

I'm using latest master branch in k/k.

Release note:

NONE

/sig testing

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 13, 2018
@Huang-Wei
Copy link
Member Author

/hold
as I should be able to provide more info after I finish my e2e test.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2018
@neolit123
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 13, 2018
@Huang-Wei
Copy link
Member Author

/hold cancel

@BenTheElder PTAL.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2018
@BenTheElder
Copy link
Member

not sure if this is actually correct, will leave to cluster/ reviewers

@roberthbailey
Copy link
Contributor

This just allows the method to not fail if those env vars aren't set, which seems fine in the skeleton implementation.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@roberthbailey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 46ad1ed into kubernetes:master Oct 17, 2018
@Huang-Wei Huang-Wei deleted the e2e-unbound-var branch October 17, 2018 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants