Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off KUBE_BUILD_CONFORMANCE to diagnose a ci-cross issue #69817

Conversation

dims
Copy link
Member

@dims dims commented Oct 15, 2018

What this PR does / why we need it:

Looking at job results, there seems to be some flakiness, let's see if
the PR that added the conformance image is the one to blame.

https://prow.k8s.io/?type=periodic&job=ci-kubernetes-cross-build
https://k8s-testgrid.appspot.com/sig-release-misc#cross-build&graph-metrics=test-duration-minutes&width=20

Change-Id: Ic26431a0e262100dec0444279d94277482972b07

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Looking at job results, there seems to be some flakiness, let's see if
the PR that added the conformance image is the one to blame.

https://prow.k8s.io/?type=periodic&job=ci-kubernetes-cross-build
https://k8s-testgrid.appspot.com/sig-release-misc#cross-build&graph-metrics=test-duration-minutes&width=20

Change-Id: Ic26431a0e262100dec0444279d94277482972b07
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 15, 2018
@dims
Copy link
Member Author

dims commented Oct 15, 2018

/assign @spiffxp
/sig release
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 15, 2018
@dims
Copy link
Member Author

dims commented Oct 15, 2018

/assign @cblecker

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @dims, I'll start another alpha.1 build once this has merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 15, 2018

/lgtm

@cblecker
Copy link
Member

/approve

Looks like this is a new option that was added in #69368, so I'm comfortable turning it off.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2018
@dims
Copy link
Member Author

dims commented Oct 15, 2018

/test pull-kubernetes-integration

@ixdy
Copy link
Member

ixdy commented Oct 15, 2018

It looks like the root cause is that both the hyperkube and conformance image Makefiles are trying to run docker run --rm --privileged multiarch/qemu-user-static:register --reset at the same time. If they're called sequentially, there should be no issue, but if they're called at the exact same time, they'll race with each other and (at least) one of them will fail.

@dims
Copy link
Member Author

dims commented Oct 15, 2018

ah wow! that's great bit of analysis @ixdy

@dims
Copy link
Member Author

dims commented Oct 15, 2018

@ixdy
Copy link
Member

ixdy commented Oct 15, 2018

flock should work, though I'm not sure if that'd cause problems for macOS builds, since I think flock is a linux-specific utility.

@k8s-ci-robot k8s-ci-robot merged commit 8418ccc into kubernetes:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants