-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hyperkube symlink creation to base image and re-enable building of conformance image #69832
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this also re-enables building the conformance image. |
@timothysc and @dougm as FYI |
@AishSundar: GitHub didn't allow me to request PR reviews from the following users: and, as, FYI. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/kind cleanup (please remove hold when you think this is ready) |
9114a8f
to
c761f77
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
flake, I think? |
/test pull-kubernetes-node-e2e |
What this PR does / why we need it: currently when building the conformance and hyperkube images, we call
docker run --rm --privileged multiarch/qemu-user-static:register --reset
to register the qemu handlers, as we run non-x86 binaries inside theDockerfile
s.This really isn't that necessary, however:
hyperkube
.I've moved the symlink creation to the
hyperkube
base image, which prevents us from needing to run this at build time, and thus from needing to run the privileged container at all.The only negative side effect of this is that the
conformance
image has some dangling symlinks to the nonexistenthyperkube
binary. But it probably shouldn't be using the hyperkube image, anyway...I've also updated the hyperkube symlinks, adding the missing
cloud-controller-manager
symlink and removing the deprecatedaggregator
symlink.This probably doesn't break anything, but with hyperkube, you never really know.
I haven't promoted the new hyperkube base image yet, so this will fail builds. If we think this approach looks reasonable, I'll work on promoting the image.
Release note:
/assign @cblecker @dims @BenTheElder @mkumatag @AishSundar