Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tokentest available to tests only #69838

Merged
merged 1 commit into from
Oct 17, 2018
Merged

make tokentest available to tests only #69838

merged 1 commit into from
Oct 17, 2018

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Oct 16, 2018 •
edited 

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/apiserver needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2018
@mikedanese
Copy link
Member Author

/approve

@ixdy
Copy link
Member

ixdy commented Oct 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@ixdy
Copy link
Member

ixdy commented Oct 16, 2018

did something in particular prompt this change?

@mikedanese
Copy link
Member Author

I'm doing a very large refactoring in #69607

I noticed this and didn't feel like this cleanup fit into the refactoring.

@mikedanese
Copy link
Member Author

Actually large refactoring will be in #69582

@mikedanese
Copy link
Member Author

@liggitt for approval

@liggitt
Copy link
Member

liggitt commented Oct 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2018
@mikedanese mikedanese added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 17, 2018
@mikedanese
Copy link
Member Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@mikedanese
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 688550b into kubernetes:master Oct 17, 2018
@mikedanese mikedanese deleted the testonly branch October 17, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@BenTheElder BenTheElder

@liggitt liggitt

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikedanese @ixdy @liggitt @k8s-ci-robot @fejta-bot @BenTheElder